Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests failing on riscv64 #883

Open
jmontleon opened this issue Jul 31, 2024 · 2 comments
Open

Tests failing on riscv64 #883

jmontleon opened this issue Jul 31, 2024 · 2 comments

Comments

@jmontleon
Copy link

We are hitting issues trying to build psycopg on Fedora 41 / rawhide riscv64
The full log is at http://fedora.riscv.rocks/kojifiles/work/tasks/7774/1737774/build.log

Failing tests:

FAILED tests/test_concurrency.py::test_eintr[ITIMER_REAL-SIGALRM] - Assertion...
FAILED tests/test_concurrency.py::test_ctrl_c_handler - assert 2.999434232711...
FAILED tests/test_concurrency_async.py::test_ctrl_c_handler - AssertionError:...
FAILED tests/test_concurrency_async.py::test_eintr[ITIMER_REAL-SIGALRM] - Ass...
FAILED tests/test_psycopg_dbapi20.py::test_date_from_ticks[0-1970-01-01] - as...
== 5 failed, 3100 passed, 172 skipped, 2307 deselected in 3345.55s (0:55:45) ===

If there is additional information I can gather or suggestions to try, please let me know and I'll be happy to.

@dvarrazzo
Copy link
Member

It is not a platform I have run any test on.

As far as I can see, several failures come from the shell or the signal handling in the tests not behaving as expected. Those tests run correctly on all the Linix/macOS platforms tested in the Github test grid, unless specifically disabled (but most likely they are only disabled on Windows and they are reasonably portable on *nix architectures).

The datetime failure is curious, especially because there are datetime tests much more extensive and comprehensive that passed no problem... or not? I don't see tests/types/test_datetime.py in your logs? I wonder why.

If you have MR to propose one-off, no problem accepting them. If you want us to consider the riscv64 platform supported you should add it to the CI test grid so we can monitor regressions.

@jmontleon
Copy link
Author

jmontleon commented Aug 1, 2024

Thank you for having a look. I'm not sure why tests/types/test_datetime.py did not run. I'll try to do some digging. I don't believe any tests are disabled in the RPM spec.

I agree the tests are not showing any issue on other platforms. Those tests passed here; https://koji.fedoraproject.org/koji/buildinfo?buildID=2518656 on others. Do you think there are any chances we're hitting a timeout? The riscv64 hardware at present is not particulary fast. We can skip them easily enough to build, but I thought I'd try to do a little digging in my spare time as well.

I apologize if my questions are a bit basic. I just got pypy bootstrapped for Fedora 41 on riscv64 and figured I'd build this and asv, which are the two packages currently dependent on pypy in Fedora and I have not done a lot of digging yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants