-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add response.future_requests_uri, deprecate response.is_permanent_redirect #5436
Comments
That method was not introduced for users to use and was part of internal machinery that was ripped out |
I think an alternative check for the first history item being a permanent redirect would be a more accurate way to calculate this? The actual permanent redirect url would be gotten from the last permanent redirect among the contiguous group of initial permanent redirects. Maybe? |
@SoniEx2 I believe |
Could we get it removed from the docs? It's hard to expect developers to consider a documented non-leading- |
it does add value fwiw - if you're doing things yourself. but don't rely on it as representative of the whole response chain. |
response.is_permanent_redirect
is unreliable/useless/dangerous for chains of redirects, just give the user the correct URI instead.example use-case:
foo
redirects temporarily tobar
, which in turn redirects permanently tobaz
. future requests should still be made tofoo
, but usingis_permanent_redirect
would lead to them being made tobaz
instead.The text was updated successfully, but these errors were encountered: