-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Barcelona label blinking #286
Comments
The style does not honor |
We are using
The planetiler docs state:
|
l'Hospitalet de Llobregat:
collides away the Barcelona label:
|
which looks correct. |
com.onthegomap.planetiler.collection.FeatureGroup.SORT_KEY_MIN is -4194304 so there should not be an overflow |
@wipfli what may be happening is although the sort order within a tile is correct, these two labels for |
Good observation. We can supply a sort key to MapLibre GL JS in that case. |
Same issue in New York at z10.6: |
Any alternative to including a sort key in the tiles for MapLibre GL JS? |
What is the tile buffer set to for the places layer? |
The buffer size is 64 I think: basemaps/tiles/src/main/java/com/protomaps/basemap/layers/Places.java Lines 290 to 299 in 57cc4b9
@msbarry have you experience previously that labels start to blink if the buffer size was set too low on a symbol layer? |
I've always seen labels blinking on gl js, it tries to optimize labels on the current viewport but that leads to labels disappearing and reappearing when you zoom in or out 😕. 64px seems like plenty, I'm only using 4px on onthegomap. I'm not exactly sure how it handles label collisions preference across tiles based on ordering within each tile but it seems like specifying a global ordering should help, except that it might show a label when one tile loads but then need to hide it when adjacent one loads. |
Seeing the same thing for Florence: https://maps.protomaps.com/#map=9.25/43.7929/11.0961&theme=light&lang=en |
@nvkelso I think we should just add a |
Here's the order of locality features in that tile (9/271/186). It matches what I'd expect based on this logic: basemaps/tiles/src/main/java/com/protomaps/basemap/layers/Places.java Lines 34 to 49 in 60e7d48
|
Added a "boxes" option on maps.protomaps.com that shows tile boundaries and label bbox boundaries. |
I propose pre-culling excess labels in tiles in #300. Once that's merged, the too large collision boxes can be trimmed down to more reasonable few pixels (needs a style PR), and the collision flicker should mostly be eliminated. |
Location
Include a link to a public URL with coordinates in the hash and zoom level.
Screenshots
z9.87:
z10.78:
Required information
The text was updated successfully, but these errors were encountered: