Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress dot-delimiter warning if ruby_package consists of a single component #7276

Merged
merged 1 commit into from
Oct 16, 2021
Merged

Suppress dot-delimiter warning if ruby_package consists of a single component #7276

merged 1 commit into from
Oct 16, 2021
+1 −1

Conversation

qnighy
Copy link
Contributor

@qnighy qnighy commented Mar 3, 2020

After #5735, something like

option ruby_package = "SomeTopLevelPb";

leads to the following warning with false description:

[libprotobuf WARNING ../../../../../src/google/protobuf/compiler/ruby/ruby_generator.cc:417] ruby_package option should be in the form of: 'A::B::C' and not 'A.B.C'

This patch suppresses the warning as this warning is not helpful in this case.

@acozzette acozzette merged commit d08bc71 into protocolbuffers:master Oct 16, 2021
@acozzette
Copy link
Member

@qnighy Thanks!

@haberman haberman mentioned this pull request Sep 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qnighy @acozzette @googlebot @protobuf-kokoro