Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Down integrate. Generate a package name suffix ".nano" for nano messages #645

Merged
merged 6 commits into from
Aug 7, 2015
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions javanano/src/test/java/com/google/protobuf/nano/NanoTest.java
Original file line number Diff line number Diff line change
@@ -40,10 +40,10 @@
import com.google.protobuf.nano.NanoReferenceTypesCompat;
import com.google.protobuf.nano.UnittestSimpleNano.SimpleMessageNano;
import com.google.protobuf.nano.UnittestSingleNano.SingleMessageNano;
import com.google.protobuf.nano.testext.Extensions;
import com.google.protobuf.nano.testext.Extensions.AnotherMessage;
import com.google.protobuf.nano.testext.Extensions.MessageWithGroup;
import com.google.protobuf.nano.testimport.UnittestImportNano;
import com.google.protobuf.nano.testext.nano.Extensions;
import com.google.protobuf.nano.testext.nano.Extensions.AnotherMessage;
import com.google.protobuf.nano.testext.nano.Extensions.MessageWithGroup;
import com.google.protobuf.nano.testimport.nano.UnittestImportNano;

import junit.framework.TestCase;

Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@ syntax = "proto3";

package map_test;

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
option java_outer_classname = "MapTestProto";

message TestMap {
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@

package protobuf_unittest;

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
option java_outer_classname = "NanoAccessorsOuterClass";

message TestNanoAccessors {
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@

package protobuf_unittest;

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
option java_multiple_files = true;

enum FileScopeEnumMultiple {
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@

package protobuf_unittest;

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
option java_outer_classname = "EnumClassNanos";

enum FileScopeEnum {
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package protobuf_unittest;

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
option java_outer_classname = "EnumValidity";

enum E {
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
syntax = "proto2";

option java_multiple_files = true;
option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";

import "google/protobuf/nano/unittest_extension_nano.proto";

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
syntax = "proto2";

option java_multiple_files = true;
option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";

import "google/protobuf/nano/unittest_extension_nano.proto";

Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
syntax = "proto2";

option java_multiple_files = true;
option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";

import "google/protobuf/nano/unittest_extension_nano.proto";

Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@

package protobuf_unittest;

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
option java_outer_classname = "NanoHasOuterClass";

message TestAllTypesNanoHas {
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@

package protobuf_unittest_import;

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
option java_outer_classname = "MultipleNameClashNano";
option java_multiple_files = true;

Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ package protobuf_unittest_import;

import "google/protobuf/nano/unittest_import_nano.proto";

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
option java_multiple_files = true;

enum FileScopeEnum {
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ package protobuf_unittest;

import "google/protobuf/nano/unittest_import_nano.proto";

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
option java_outer_classname = "NanoOuterClass";

// Same as TestAllTypes but with the nano runtime.
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@

package protobuf_unittest_import;

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
// Explicit outer classname to suppress legacy info.
option java_outer_classname = "UnittestRecursiveNano";

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package protobuf_unittest;

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
option java_outer_classname = "NanoReferenceTypes";

message TestAllTypesNano {
Original file line number Diff line number Diff line change
@@ -34,7 +34,7 @@ package protobuf_unittest;

import "google/protobuf/nano/unittest_nano.proto";

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
option java_multiple_files = true;

// A container message for testing the merging of repeated fields at a
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@

package protobuf_unittest;

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
option java_outer_classname = "NanoRepeatedPackables";

enum Enum {
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@

package protobuf_unittest_import;

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
// Explicit outer classname to suppress legacy info.
option java_outer_classname = "UnittestSimpleNano";

Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@

package protobuf_unittest_import;

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";

message SingleMessageNano {
}
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@

package protobuf_unittest_import;

option java_package = "com.google.protobuf.nano";
option java_package = "com.google.protobuf";
// Explicit outer classname to suppress legacy info.
option java_outer_classname = "UnittestStringutf8Nano";

5 changes: 3 additions & 2 deletions src/google/protobuf/any.pb.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions src/google/protobuf/api.pb.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion src/google/protobuf/compiler/javanano/javanano_generator.cc
Original file line number Diff line number Diff line change
@@ -67,8 +67,15 @@ void UpdateParamsRecursively(Params& params,
file->name(), file->options().java_outer_classname());
}
if (file->options().has_java_package()) {
string result = file->options().java_package();
if (!file->options().javanano_use_deprecated_package()) {
if (!result.empty()) {
result += ".";
}
result += "nano";
}
params.set_java_package(
file->name(), file->options().java_package());
file->name(), result);
}
if (file->options().has_java_multiple_files()) {
params.set_java_multiple_files(
8 changes: 8 additions & 0 deletions src/google/protobuf/compiler/javanano/javanano_helpers.cc
Original file line number Diff line number Diff line change
@@ -200,6 +200,14 @@ string FileJavaPackage(const Params& params, const FileDescriptor* file) {
if (!result.empty()) result += '.';
result += file->package();
}

if (!file->options().javanano_use_deprecated_package()) {
if (!result.empty()) {
result += ".";
}
result += "nano";
}

return result;
}
}
Loading