Fix Ruby module name generation when the ruby_package option is used (again) #5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… option is used (protocolbuffers#5735)"" This reverts commit bb211e8.
|
@TeBoring let me know if I've missed any more of the relevant build files. |
TeBoring
approved these changes
Mar 2, 2019
bithium
pushed a commit
to bithium/protobuf
that referenced
this pull request
Sep 4, 2023
…(again) (protocolbuffers#5794) * Revert "Revert "Fix Ruby module name generation when the ruby_package option is used (protocolbuffers#5735)"" This reverts commit bb211e8. * add new files to Makefile.am
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5791, to restore #5735 with the additional change of adding newly added files to `src/Makefile.am'