Extra large kmers #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for k-mers up to 128.
Currently it is about 4 times slower for k-mers >64 than for k-mers up to 64.
My guess that the additional 2 times slowdown (2 times slower is required as software implementation of the type) comes from additional operations needed to compute hashes etc.
I.g. this could be optimized but i don't think it's a priority. Even the fact that those k are supported and they are not terribly slow should be an advantage.
Currently the only downside to this PR is rouhgly 2 times slowdown of compilation. I'll see what can be done with it.
EDIT: the compilation now takes about 3sec on my PC which i.g. should be okay.