-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pimped testsuite for PostgreSQL #428
Conversation
…ite the table from `bookstore`.
…s. Better for debugging.
…cessing it in getForeignTable().
…earch_path`. Fixed `atthasdef` check - it should be boolean.
…er that adds the `group by` SQL in Criteria's `createSelectSql`. PostgreSQL needs to have all selected columns (without aggregate functions) in the `group by` statement. This fix fills up all selected columns that aren't in the group by statement yet. Fixed also missing `use`.
…ml to standalone shell scripts. Added the PostgreSQL phpunit call. Removed also --dev since it's the default now in composer.
In detail: - added at mysql tests the `mysql` group. - fixed some object creations where some fields have no value (but required). that throws otherwise a NOTNULL constraint error in databases that do now automatically converts not-existing values (in inserts) into empty-strings (as mysql it does in NN columns) - fixed the test of namespace tests. - wrap the most expected SQL strings with a method that converts the SQL to the current db (replaces the quoteIdentifier)
…t have full bash.
@@ -20,7 +20,7 @@ | |||
"symfony/yaml": "~2.2", | |||
"symfony/console": "~2.2", | |||
"symfony/finder": "~2.2", | |||
"symfony/validator": "~2.2", | |||
"symfony/validator": "2.2.*@dev", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why dev here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because it seems they don't have yet a official version with my fix included for #427
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense... I forgot about that..
❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ |
Let me know if it is mergeable as is. However I am curious about the |
it's so much mergeable as a PR can be 👯 |
Pimped testsuite for PostgreSQL
Danke! |
Avec plaisir! |
Made it completely PostgreSQL compatible and added it to the travis build file.
PostgreSQL needed some bugfixes to work with all tests (even to setup the fixtures).