Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pimped testsuite for PostgreSQL #428

Merged
merged 18 commits into from
Aug 14, 2013
Merged

Pimped testsuite for PostgreSQL #428

merged 18 commits into from
Aug 14, 2013

Conversation

marcj
Copy link
Member

@marcj marcj commented Aug 14, 2013

Made it completely PostgreSQL compatible and added it to the travis build file.

PostgreSQL needed some bugfixes to work with all tests (even to setup the fixtures).

marcj added 18 commits August 14, 2013 21:21
…earch_path`. Fixed `atthasdef` check - it should be boolean.
…er that adds the `group by` SQL in Criteria's `createSelectSql`.

PostgreSQL needs to have all selected columns (without aggregate functions) in the `group by` statement.
This fix fills up all selected columns that aren't in the group by statement yet.
Fixed also missing `use`.
…ml to standalone shell scripts.

Added the PostgreSQL phpunit call.
Removed also --dev since it's the default now in composer.
In detail:
 - added at mysql tests the `mysql` group.
 - fixed some object creations where some fields have no value (but required). that throws otherwise a NOTNULL constraint error in databases that do now automatically converts not-existing values (in inserts) into empty-strings (as mysql it does in NN columns)
 - fixed the test of namespace tests.
 - wrap the most expected SQL strings with a method that converts the SQL to the current db (replaces the quoteIdentifier)
@@ -20,7 +20,7 @@
"symfony/yaml": "~2.2",
"symfony/console": "~2.2",
"symfony/finder": "~2.2",
"symfony/validator": "~2.2",
"symfony/validator": "2.2.*@dev",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why dev here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because it seems they don't have yet a official version with my fix included for #427

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense... I forgot about that..

@willdurand
Copy link
Contributor

❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️ ❤️

@willdurand
Copy link
Contributor

Let me know if it is mergeable as is. However I am curious about the @dev stuff for the Validator component.

@marcj
Copy link
Member Author

marcj commented Aug 14, 2013

it's so much mergeable as a PR can be 👯

willdurand added a commit that referenced this pull request Aug 14, 2013
Pimped testsuite for PostgreSQL
@willdurand willdurand merged commit c33b5ad into propelorm:master Aug 14, 2013
@willdurand
Copy link
Contributor

Danke!

@marcj
Copy link
Member Author

marcj commented Aug 14, 2013

Avec plaisir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants