Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some code smells reported by PHPStorm. #1810

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Conversation

dereuromark
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2021

Codecov Report

Merging #1810 (fd1eb6c) into master (431b8d0) will decrease coverage by 0.00%.
The diff coverage is 87.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1810      +/-   ##
============================================
- Coverage     87.85%   87.84%   -0.01%     
  Complexity     7816     7816              
============================================
  Files           281      281              
  Lines         22710    22713       +3     
============================================
+ Hits          19951    19953       +2     
- Misses         2759     2760       +1     
Flag Coverage Δ
5-max 87.84% <87.50%> (-0.01%) ⬇️
7.4 87.84% <87.50%> (-0.01%) ⬇️
agnostic 68.54% <87.50%> (-0.01%) ⬇️
mysql 70.55% <87.50%> (-0.01%) ⬇️
pgsql 70.43% <87.50%> (-0.01%) ⬇️
sqlite 68.47% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/Propel/Runtime/Collection/OnDemandCollection.php 63.15% <ø> (ø)
src/Propel/Generator/Builder/DataModelBuilder.php 88.46% <75.00%> (-0.86%) ⬇️
...c/Propel/Runtime/ActiveQuery/InstancePoolTrait.php 100.00% <100.00%> (ø)
...Propel/Runtime/DataFetcher/AbstractDataFetcher.php 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 431b8d0...fd1eb6c. Read the comment docs.

@dereuromark dereuromark merged commit 4f4ef1b into master Dec 7, 2021
@dereuromark dereuromark deleted the bugfix/cleanup branch December 7, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants