Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alertmanager config options to Alertmanager crd #2766

Closed
benjaminhuo opened this issue Sep 18, 2019 · 10 comments
Closed

Add Alertmanager config options to Alertmanager crd #2766

benjaminhuo opened this issue Sep 18, 2019 · 10 comments

Comments

@benjaminhuo
Copy link

benjaminhuo commented Sep 18, 2019

What is missing?
Currently Alertmanager crd spec doesn't have config options like prometheus crd

Just wondering if it's reasonable to add alert manager config to alertmanager crd spec?

And then regenerate the alertmanager secrets and then call alertmanager's reload interface?

Why do we need it?
Currently we've to edit the alertmanager secret manually and then reload

@brancz
Copy link
Contributor

brancz commented Sep 20, 2019

The reload should happen automatically. The reason we haven't added the Alertmanager configuration itself to the CRD is because we see similar collaboration potential with Alertmanager route configurations and receivers as there is with ServiceMonitors. As in each namespace should be able to specify these for themselves.

@benjaminhuo
Copy link
Author

Thanks for the reply :)
Yes, the reload occurs whenever the secret is updated
You mean we should consider abstracting route and receivers as servicemonitor does?

@brancz
Copy link
Contributor

brancz commented Oct 7, 2019

Yes exactly. It'll be some time, but we already have some of this work planned.

@benjaminhuo
Copy link
Author

benjaminhuo commented Oct 7, 2019

Great! The route is kind of recursive, it's a bit complex.
Break the big alert config into smaller parts is a good idea 👍
I have been thinking to add more to alert crd , it's a good path to go.

@benjaminhuo benjaminhuo changed the title Add AlertManager config options to Alertmanager crd Add Alertmanager config options to Alertmanager crd Oct 7, 2019
@midnightconman
Copy link
Contributor

I would like to see this happen and would be willing to help out... would we first want to see schema, before we start working on code?

@lilic
Copy link
Contributor

lilic commented Jan 15, 2020

Yes defining a schema in advance would be good, feel free to write up initial outline so we have something to start with. Thanks!

cc @simonpasquier

@brancz
Copy link
Contributor

brancz commented Jan 20, 2020

There are multiple discussions happening around this, I think we need to start deduplicating (#2927, #1528).

@simonpasquier
Copy link
Contributor

Hello! I've started a design document:
https://docs.google.com/document/d/1aVVttvocop8zNezwrNFbHh_HKRW_fhJUZqhmrr8fGK0/edit?usp=sharing

Feel free to comment there...

@benjaminhuo
Copy link
Author

@simonpasquier That's great! Will take a look at this!

@simonpasquier
Copy link
Contributor

Closed by #3451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants