Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Cortex endpoints ? #156

Open
o11y16 opened this issue Aug 23, 2023 · 4 comments
Open

Support for Cortex endpoints ? #156

o11y16 opened this issue Aug 23, 2023 · 4 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@o11y16
Copy link

o11y16 commented Aug 23, 2023

Hello,

In my use case I need to inject labels to given queries to be sent to Cortex.
Prom-label-proxy has the solution for that but doesn't support Cortex endpoints, do you intend to do that ?
what are please the things to consider in this case ?
@simonpasquier
Copy link
Contributor

I've got no experience with Cortex and its API. This project aims at supporting any project which is compatible with the Prometheus and Alertmanager APIs (Thanos for instance).

What would be the differences for Cortex?

@o11y16
Copy link
Author

o11y16 commented Aug 24, 2023 •
edited
Loading

The paths of the endpoints are different is some cases, ex:
/prometheus/api/v1/query
/prometheus/api/v1/query_range
/prometheus/api/v1/query_exemplars
...

Is it just a matter of modifying these paths ? because other than that Cortex is compatible with Prometheus.

@simonpasquier
Copy link
Contributor

Ok so it would be more the ability to specify a path prefix to append to the request being forwarded to Cortex then?

I'm also curious to know why you'd need prom-label-proxy in front of the Cortex API since I believed that Cortex is already multi-tenant.

@o11y16
Copy link
Author

o11y16 commented Aug 25, 2023

Yes that would be it, for the main endpoints. (some supported by the proxy are not by Cortex)

In my case the provider of the request is not aware of the tenant it is bound to. And we have a classification of tenants that relies on both Cortex tenant concept and labels.

@simonpasquier simonpasquier added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. labels Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@simonpasquier @o11y16