Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Prometheus Remote Write 2.0 #35

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Proposal: Prometheus Remote Write 2.0 #35

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
99ccd7b
remote write 2.0 proposal
alexgreenbank Apr 9, 2024
a605985
Updated proposal with Alternatives entry for use of HEAD
alexgreenbank Apr 10, 2024
4f3124e
Updated proposal: new structure, all decisions outlined.
bwplotka Apr 18, 2024
a1e9889
update proposal notes about;
cstyan May 16, 2024
46f4607
Merge pull request #36 from prometheus/bwplotka/rw
bwplotka May 22, 2024
90e1801
Progressed!
bwplotka Jun 4, 2024
3d85921
Last touches.
bwplotka Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Updated proposal with Alternatives entry for use of HEAD 
Signed-off-by: alexgreenbank <alex.greenbank@grafana.com>
  • Loading branch information
@alexgreenbank
alexgreenbank committed Apr 10, 2024
commit a605985447d51557b2b4a0ef90b8549547ec31e0
1 change: 1 addition & 0 deletions proposals/2024-04-09_remote-write-20.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ Details can be found in the [Remote Write 2.0 Draft Specification](https://docs.
The section stating potential alternatives. Highlight the objections reader should have towards your proposal as they read it. Tell them why you still think you should take this path [[ref](https://twitter.com/whereistanya/status/1353853753439490049)]

1. (See some comments in the [Remote Write 2.0 Draft Specification](https://docs.google.com/document/d/1PljkX3YLLT-4f7MqrLt7XCVPG3IsjRREzYrUzBxCPV0/edit#heading=h.3p42p5s8n0ui).)
2. The use of `HEAD` to probe the remote receiver for protocol support was certainly a point that caused some discussion. The alternative is to follow [the existing 1.0 spec](https://prometheus.io/docs/concepts/remote_write_spec/) and `Senders who wish to send in a format >1.x MUST start by sending an empty 1.x, and see if the response says the receiver supports something else.`. This is still possible under this 2.0 proposal but (IMHO) the availibility of the `HEAD` makes for a "cleaner" interface as `HEAD` implies an idempotent operation that, barring separate metric updates, should have no other side effects.

## Action Plan

Expand Down
Loading