chore: bump workflow node version to 20 #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lru-cache` has dropped support for Node 18, and now requires Node 20 or higher. When `projen` creates new projects that use jest, those pull in `lru-cache` using the following dependency path: ``` jest > @jest/core > @jest/transform > @babel/core > @babel/helper-compilation-targets > lru-cache ``` That happens to install the newest `lru-cache` version, which no longer works on Node 18, and so our tests fail. Bump our workflow Node to 20 to at least make our PR build pass again. I don't know if this should have bearing on projen's minimum node version; I suppose *technically* not, and people with a working `package-lock` will be unaffected... but it might be hard to explain the intricacies to users.
mrgrain
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lru-cachehas dropped support for Node 18, and now requires Node 20 or higher.When
projencreates new projects that use jest, it pulls inlru-cacheusing the following dependency path:That happens to install the newest
lru-cacheversion, which no longer works on Node 18, and so our tests fail.Bump our workflow Node to 20 to at least make our PR build pass again (should we use
lts/*to be done with this periodic breakage?)This means that
projen new typescript-appwill no longer work on Node 18.I don't know if this should have bearing on projen's minimum Node version; I suppose technically not, and people with a working
package-lockwill be unaffected... but it might be hard to explain the intricacies to users.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.