Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pull out generic Step from JobStep #1787

Merged
merged 2 commits into from
Apr 21, 2022
Merged

chore: pull out generic Step from JobStep #1787

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8f18ca8
chore: pull out a generic step from jobstep
kaizencc Apr 21, 2022
5bfc007
api changes
kaizencc Apr 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: pull out a generic step from jobstep
  • Loading branch information
@kaizencc
kaizencc committed Apr 21, 2022
commit 8f18ca87f719ec03754ba9d132f0581bdcee7e5a
9 changes: 7 additions & 2 deletions src/github/workflows-model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,9 +258,9 @@ export interface RunSettings {
}

/**
* A job step.
* A generic step
*/
export interface JobStep {
export interface Step {
/**
* A unique identifier for the step. You can use the id to reference the
* step in contexts.
Expand Down Expand Up @@ -306,7 +306,12 @@ export interface JobStep {
* You can also set environment variables for the entire workflow or a job.
*/
readonly env?: Record<string, string>;
}

/**
* A job step
*/
export interface JobStep extends Step {
/**
* Prevents a job from failing when a step fails. Set to true to allow a job
* to pass when this step fails.
Expand Down