Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade deps and improve upgrade task resiliency #1698

Merged
merged 3 commits into from
Mar 21, 2022
Merged

fix: upgrade deps and improve upgrade task resiliency #1698

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5868228
chore: upgrade deps
Chriscbr Mar 21, 2022
073b755
upgrade npm-check-updates before everything else
Chriscbr Mar 21, 2022
f59c55d
chore: self mutation
invalid-email-address Mar 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: self mutation 
Signed-off-by: github-actions <github-actions@github.com>
  • Loading branch information
github-actions committed Mar 21, 2022
commit f59c55d52133bc8574b5510de7f141a0ce5f4089
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion src/javascript/upgrade-dependencies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,12 @@ export class UpgradeDependencies extends Component {
// update npm-check-updates before everything else, in case there is a bug
// in it or one of its dependencies. This will make upgrade workflows
// slightly more stable and resilient to upstream changes.
task.exec(this._project.package.renderUpgradePackagesCommand([], ['npm-check-updates']));
task.exec(
this._project.package.renderUpgradePackagesCommand(
[],
["npm-check-updates"]
)
);

for (const dep of ["dev", "optional", "peer", "prod", "bundle"]) {
const ncuCommand = [
Expand Down