Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upgrade-task): Fixed upgrade task to include line ending in package.json #1650

Merged
merged 3 commits into from
Mar 4, 2022
+6 −1
Merged

fix(upgrade-task): Fixed upgrade task to include line ending in package.json #1650

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2c1084
fix(upgrade-task): Fixed upgrade task to include line ending in packa…
AminFazlMondo Mar 1, 2022
8a669f4
Updated to only affect npm package manager
AminFazlMondo Mar 1, 2022
0b2d244
Merge branch 'main' into fix/UpgradeLineEndings
mergify[bot] Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(upgrade-task): Fixed upgrade task to include line ending in packa… 
…ge.json
  • Loading branch information
@AminFazlMondo
AminFazlMondo committed Mar 1, 2022
commit c2c10844a673d205de17bd261ff3c0dfef713db8
2 changes: 1 addition & 1 deletion src/javascript/node-package.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1098,7 +1098,7 @@ export class NodePackage extends Component {
pkg.devDependencies = sorted(devDeps);
pkg.peerDependencies = sorted(peerDeps);

const updated = JSON.stringify(pkg, undefined, 2);
const updated = `${JSON.stringify(pkg, undefined, 2)}\n`;

if (original === updated) {
return false;
Expand Down