Apply suggestions from code review

Co-authored-by: Christopher Rybicki <crybicki98@gmail.com>
projen · mergify · Jan 2, 2022 · Dec 20, 2021 · Dec 20, 2021 · Dec 20, 2021
commit 8124b47611c9f63e7d79cf391b86964ede98bdc2
diff --git a/docs/gitlab.md b/docs/gitlab.md
@@ -1,12 +1,12 @@
 # GitLab
 
-[GitLab CI/CD](https://docs.gitlab.com/ee/ci/yaml/gitlab_ci_yaml.html) uses a `.gitlab-ci.yml` configuration located in the root of your repository. Optionally `.gitlab-ci.yml` files can be split into multiple files to increase readability, or reduce duplication of the same configuration in multiple places by using [include](https://docs.gitlab.com/ee/ci/yaml/#include).
+[GitLab CI/CD](https://docs.gitlab.com/ee/ci/yaml/gitlab_ci_yaml.html) uses a `.gitlab-ci.yml` file located at the root of your repository to specify continuous integration and continuous deployment processes. GitLab CI configuration files can be split into multiple files using the [include](https://docs.gitlab.com/ee/ci/yaml/#include) fields in order to increase readability or reduce duplication of the same configuration in multiple places.
 
 ## Creating a configuration
 
 We support the creation of GitLab CI/CD Configurations through a `CiConfiguration` class and a higher level `GitlabConfiguration` and `NestedConfiguration` classes. To create a GitLab configuration you must first create a [project](./project.md) to assign the configuration to.
 
-When using any of the `gitlab` classes. The `.gitlab-ci.yml` is always located at the root of the project while other configuration files are located in the `.gitlab\ci-templates\` subdirectory.
+When using GitLab for CI, the `.gitlab-ci.yml` is always located at the root of the project while other configuration files are located in the `.gitlab\ci-templates\` subdirectory.
 
 ```js
 const { typescript, gitlab } = require('projen');

diff --git a/src/gitlab/configuration.ts b/src/gitlab/configuration.ts
@@ -43,7 +43,7 @@ export class CiConfiguration extends Component {
    * The workflow YAML file.
    */
   public readonly file: YamlFile;
-  public default?: Default;
+  public readonly default?: Default;
   /**
    * Can be `Include` or `Include[]`. Each `Include` will be a string, or an
    * object with properties for the method if including external YAML file. The external
@@ -54,15 +54,15 @@ export class CiConfiguration extends Component {
    * A special job used to upload static sites to Gitlab pages. Requires a `public/` directory
    * with `artifacts.path` pointing to it.
    */
-  public pages?: Job;
+  public readonly pages?: Job;
   public readonly services: Array<Service | string> = [];
   /**
    * Groups jobs into stages. All jobs in one stage must complete before next stage is
    * executed. Defaults to ['build', 'test', 'deploy'].
    */
   public readonly stages: string[] = [];
   public readonly variables: Record<string, number | VariableConfig | string> = {};
-  public workflow?: Workflow;
+  public readonly workflow?: Workflow;
   public readonly jobs: Record<string, Job> = {};
 
   constructor(project: Project, name: string, options?: CiConfigurationOptions) {