Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update libcalico-go to latest version #2754

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Update libcalico-go to latest version #2754

merged 1 commit into from
Apr 8, 2021

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Apr 6, 2021 •
edited
Loading

This PR updates libcalico-go to the latest version

Just to document the other changes were because of the following Kubernetes libraries changes:

@rikatz rikatz requested a review from a team as a code owner April 6, 2021 19:40
@marvin-tigera marvin-tigera added this to the Calico v3.19.0 milestone Apr 6, 2021
@rikatz rikatz force-pushed the libcalico-update branch from d3b903e to 11c8960 Compare April 6, 2021 21:10
@rikatz rikatz force-pushed the libcalico-update branch from 11c8960 to 1cfe2b6 Compare April 6, 2021 21:29
@marvin-tigera
Copy link
Contributor

Removing "merge-when-ready" label due to new commits

@rikatz rikatz force-pushed the libcalico-update branch from 1cfe2b6 to 7cbcfe7 Compare April 6, 2021 22:12
@rikatz rikatz force-pushed the libcalico-update branch from 7cbcfe7 to 45150fb Compare April 6, 2021 22:27
@caseydavenport
Copy link
Member

/sem-approve

@fasaxc
Copy link
Member

fasaxc commented Apr 7, 2021

Thanks @rikatz. Looks like the FVs have failed due to a known issue that will be fixed by #2755 ; hopefully we'll get that fixed in the next day or so and then your change can be rebased on top of the fix.

@fasaxc fasaxc requested a review from tomastigera April 7, 2021 10:27
tomastigera
tomastigera approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@tomastigera tomastigera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@caseydavenport
Copy link
Member

@rikatz it seems that you and @sridhartigera have reached a bit of a stalemate, where each PR is waiting on the other's!

I'm going to merge this and the @sridhartigera can rebase on top to finish off.

@caseydavenport caseydavenport merged commit 9f2bfb3 into projectcalico:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomastigera tomastigera tomastigera approved these changes

Assignees
No one assigned
Labels
docs-not-required release-note-not-required
Projects
None yet
Milestone
Calico v3.19.0
Development

Successfully merging this pull request may close these issues.
5 participants
@rikatz @marvin-tigera @caseydavenport @fasaxc @tomastigera