Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to include missing Python dependency and ensure file copying #2003

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tjsweetblack
Copy link

This pull request updates the Dockerfile to resolve a missing dependency issue that prevented Profanity from starting in the Docker container. Specifically:

Added Python 3 and necessary development libraries to the Dockerfile dependencies.
Ensured all source files are correctly copied into the container during the build process.

These changes enable Profanity to build and run successfully within the Debian-based Docker container.

How to Test the Functionality

**Build the Docker Image:**

docker build -t profanity_test .

Run the Container:

docker run -it profanity_test /bin/bash

Navigate to the Profanity Directory:

cd /usr/src/profanity

Start Profanity:

./profanity

Verify:

Confirm that Profanity starts without any errors related to missing libraries.
Test basic commands within Profanity to ensure functionality.

… are being copied to the image, debian docker libpython3.11.so.1.0 library error fixed
… are being copied to the image, debian docker libpython3.11.so.1.0 library error fixed, added back comments
@jubalh
Copy link
Member

jubalh commented Oct 29, 2024

Thanks for your PR. I left a couple of comments. Basically you mention in your commit that you want to add python3 but in reality it seems you are doing a lot of more things in this change.

@tjsweetblack
Copy link
Author

Sorry it is my first pull request, I did switch the bottom lines of the docker file to the top and set the copy command to .. which means all, in order to copy all files to the docket image for the line switch it’s more about formatting only.

@jubalh
Copy link
Member

jubalh commented Nov 18, 2024

Please answer in the dedicated fields above when you are ready :)
And then superseide this PR by ammending the commit. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants