Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor code refactoring #1103

Merged
merged 2 commits into from
Jan 5, 2020
Merged

chore: minor code refactoring #1103

merged 2 commits into from
Jan 5, 2020

Conversation

jamesgeorge007
Copy link
Contributor

@jamesgeorge007 jamesgeorge007 commented Jan 3, 2020 •
edited
Loading

Minor stylistic code refactoring as a first step to address #1102

@jamesgeorge007 jamesgeorge007 requested a review from a team as a code owner January 3, 2020 17:15
gr2m
gr2m reviewed Jan 3, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
@jamesgeorge007 jamesgeorge007 requested a review from gr2m January 4, 2020 02:49
@jamesgeorge007 jamesgeorge007 changed the title fix(cli): misleading version info chore: minor code refactoring Jan 4, 2020
@jamesgeorge007 jamesgeorge007 force-pushed the hotfix/fixup-version-info branch from e78519e to 525886d Compare January 4, 2020 02:53
@gr2m gr2m merged commit 4fdcde3 into probot:master Jan 5, 2020
@jamesgeorge007 jamesgeorge007 deleted the hotfix/fixup-version-info branch January 6, 2020 02:18
@jamesgeorge007 jamesgeorge007 mentioned this pull request Jan 6, 2020
Merged
@probotbot
Copy link

🎉 This PR is included in version 9.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr2m gr2m gr2m approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamesgeorge007 @probotbot @gr2m