Add target-gen reformat and hexify some YAML properties
#2548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Little brother, he says. PR is still |
bugadani
changed the title
target-gen refresh and hexify some YAMLtarget-gen refresh and hexify some YAML properties
|
I did my best to keep the comments, but it's evident we'll need to somehow automate that. |
noppej
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
There are three ways I can think of to de-risk this a little:
- Identify a cross section of targets that need to be tested, and use the Matrix channel to do a call for volunteers to test this branch.
- Merge this to master, and be sure we don't release for at least 2 months. This will allow all master branch users and contributors to implicitly test this. If there are surprises, we can easily restore in master.
- Keep a compressed version of the pre-change yaml's in master for now, with a flag on probe-rs to revert these if a user wants to do comparison troubleshooting.
I'm OK with 2 or 3, if you are willing to 'recover' when the need arises.
|
As this is basically just a bunch of reformatting, I'm willing to bet some of my free time that merging this is safe :) We can always revert the merge commit. |
bugadani
changed the title
target-gen refresh and hexify some YAML propertiestarget-gen reformat and hexify some YAML properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the little brother of #2543 without the target and flash algo deduplication.