Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: Fix debug asssert in profile subcommand args parsing #1825

Merged
merged 1 commit into from
Oct 16, 2023
Merged

cli: Fix debug asssert in profile subcommand args parsing #1825

merged 1 commit into from
Oct 16, 2023

Conversation

Tiwalun
Copy link
Member

@Tiwalun Tiwalun commented Oct 15, 2023

Rename the struct to avoid an assert.

Fixes #1808.

@Tiwalun Tiwalun requested a review from Yatekii October 15, 2023 19:21
Yatekii
Yatekii approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@Yatekii Yatekii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont we have to rename all the Cmds ro make this work?

@Tiwalun
Copy link
Member Author

Tiwalun commented Oct 16, 2023

Dont we have to rename all the Cmds ro make this work?

The problem seems to have happened because the profile subcommand includes the struct from the run subcommand. And both of them were named Cmd. Other commands don't seem to have this problem.

@Tiwalun Tiwalun added this pull request to the merge queue Oct 16, 2023
Merged via the queue into master with commit 61beba5 Oct 16, 2023
@Tiwalun Tiwalun deleted the fix/clap-debug-assert branch October 16, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yatekii Yatekii Yatekii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug builds of cli can't run 'profile' subcommand
2 participants
@Tiwalun @Yatekii