Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to @primer/primtives@8.2.0 and @primer/stylelint-config@13.0.0-rc #2634

Merged
merged 12 commits into from
Jun 3, 2024
Merged

Upgrade to @primer/primtives@8.2.0 and @primer/stylelint-config@13.0.0-rc #2634

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
59462ba
Upgrade primer/primitives to latest
jonrohan Jun 3, 2024
6d8d304
Change theme imports
jonrohan Jun 3, 2024
8e12988
Remove empty css imports
jonrohan Jun 3, 2024
c3942f4
upgrade
jonrohan Jun 3, 2024
0a0bc25
Replacing $spacing variables
jonrohan Jun 3, 2024
c0ad6ee
Replace a few direct values
jonrohan Jun 3, 2024
3c2c869
Fix stylelint add disables script
jonrohan Jun 3, 2024
0c85cde
Add stylelint disables to exisiting files
jonrohan Jun 3, 2024
9b52151
Fix ci run
jonrohan Jun 3, 2024
1d3e580
Create young-foxes-battle.md
jonrohan Jun 3, 2024
2aa8243
Updates from suggestions
jonrohan Jun 3, 2024
d0b1720
Fix theme in storybook
jonrohan Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add stylelint disables to exisiting files
  • Loading branch information
@jonrohan
jonrohan committed Jun 3, 2024
commit 0c85cdeac287abb4055c33b49d9ff89135d00870
1 change: 1 addition & 0 deletions src/buttons/misc.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@

&.inline {
position: relative;
// stylelint-disable-next-line primer/spacing
top: -1px;
display: inline-block;
// stylelint-disable-next-line primer/spacing
Expand Down
1 change: 1 addition & 0 deletions src/forms/form-control.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@ textarea.form-control {

img {
position: relative;
// stylelint-disable-next-line primer/spacing
top: -2px;
}
}
Expand Down
1 change: 1 addition & 0 deletions src/forms/form-group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@
&::before {
position: absolute;
bottom: 100%;
// stylelint-disable-next-line primer/spacing
left: 10px;
z-index: 15;
width: 0;
Expand Down
1 change: 1 addition & 0 deletions src/labels/issue-labels.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

.g-emoji {
position: relative;
// stylelint-disable-next-line primer/spacing
top: -0.05em;
display: inline-block;
font-size: 1em;
Expand Down
1 change: 0 additions & 1 deletion src/layout/grid-offset.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

// Offset Columns

// stylelint-disable primer/spacing
@each $breakpoint, $variant in $responsive-variants {
@include breakpoint($breakpoint) {
.offset#{$variant}-1 { margin-left: (1 * 0.0833333333 * 100%) !important; }
Expand Down
6 changes: 6 additions & 0 deletions src/layout/page-layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ $Layout-responsive-variant-max-breakpoint: 'md' !default;

@mixin Layout-line-divider {
position: absolute;
// stylelint-disable-next-line primer/spacing
left: calc(var(--Layout-outer-spacing-x) * -1);
display: block;
width: calc(100% + (var(--Layout-outer-spacing-x) * 2));
Expand All @@ -37,6 +38,7 @@ $Layout-responsive-variant-max-breakpoint: 'md' !default;
@mixin Layout-filled-divider {
position: absolute;
bottom: calc(var(--base-size-8) * -1);
// stylelint-disable-next-line primer/spacing
left: calc(var(--Layout-outer-spacing-x) * -1);
display: block;
width: calc(100% + (var(--Layout-outer-spacing-x) * 2));
Expand Down Expand Up @@ -255,6 +257,7 @@ $Layout-responsive-variant-max-breakpoint: 'md' !default;
&::before {
@include Layout-line-divider;

// stylelint-disable-next-line primer/spacing
top: calc(#{$border-width * -1} - var(--Layout-row-gap));
}
}
Expand All @@ -267,6 +270,7 @@ $Layout-responsive-variant-max-breakpoint: 'md' !default;
&::after {
@include Layout-line-divider;

// stylelint-disable-next-line primer/spacing
bottom: calc(#{$border-width * -1} - var(--Layout-row-gap));
}
}
Expand All @@ -279,6 +283,7 @@ $Layout-responsive-variant-max-breakpoint: 'md' !default;
&::after {
@include Layout-filled-divider;

// stylelint-disable-next-line primer/spacing
top: calc(var(--base-size-8) * -1 - var(--Layout-row-gap));
jonrohan marked this conversation as resolved.
Show resolved Hide resolved
}
}
Expand All @@ -291,6 +296,7 @@ $Layout-responsive-variant-max-breakpoint: 'md' !default;
&::before {
@include Layout-filled-divider;

// stylelint-disable-next-line primer/spacing
bottom: calc(var(--base-size-8) * -1 - var(--Layout-row-gap));
jonrohan marked this conversation as resolved.
Show resolved Hide resolved
}
}
Expand Down
1 change: 1 addition & 0 deletions src/markdown/lists.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
}

li + li {
// stylelint-disable-next-line primer/spacing
margin-top: $em-spacer-3;
}

Expand Down
2 changes: 2 additions & 0 deletions src/marketing/links/link.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
&::after,
&.link-emphasis-mktg::before {
position: absolute;
// stylelint-disable-next-line primer/spacing
bottom: -0.15em;
left: 0;
width: calc(100% - 1em);
Expand Down Expand Up @@ -44,6 +45,7 @@

&.arrow-target-mktg {
.arrow-symbol-mktg {
// stylelint-disable-next-line primer/spacing
margin-left: -$em-spacer-3;
}
}
Expand Down
8 changes: 8 additions & 0 deletions src/marketing/utilities/layout.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,24 @@
@include breakpoint($breakpoint) {
@each $scale, $size in $spacer-map-extended {
@if ($size != 0 or $variant != '') {
// stylelint-disable-next-line primer/spacing
.top#{$variant}-#{$scale} { top: $size !important; }
// stylelint-disable-next-line primer/spacing
.right#{$variant}-#{$scale} { right: $size !important; }
// stylelint-disable-next-line primer/spacing
.bottom#{$variant}-#{$scale} { bottom: $size !important; }
// stylelint-disable-next-line primer/spacing
.left#{$variant}-#{$scale} { left: $size !important; }
}

@if ($size != 0) {
// stylelint-disable-next-line primer/spacing
.top#{$variant}-n#{$scale} { top: -$size !important; }
// stylelint-disable-next-line primer/spacing
.right#{$variant}-n#{$scale} { right: -$size !important; }
// stylelint-disable-next-line primer/spacing
.bottom#{$variant}-n#{$scale} { bottom: -$size !important; }
// stylelint-disable-next-line primer/spacing
.left#{$variant}-n#{$scale} { left: -$size !important; }
}
}
Expand Down
1 change: 1 addition & 0 deletions src/navigation/subnav.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@

.subnav-search-icon {
position: absolute;
// stylelint-disable-next-line primer/spacing
top: 9px;
left: var(--base-size-8);
display: block;
Expand Down
1 change: 1 addition & 0 deletions src/support/mixins/misc.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
&::after,
&::before {
position: absolute;
// stylelint-disable-next-line primer/spacing
top: 11px;
right: 100%;
left: calc(var(--base-size-8) * -1);
Expand Down
Loading