Add LOOCV config option #2153
Draft
Add LOOCV config option #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uekerman
reviewed
Dec 18, 2024
| @@ -75,7 +75,7 @@ struct BackendSelector { | |||
| // Specialization for the RBF Eigen backend | |||
| template <typename RBF> | |||
| struct BackendSelector<RBFBackend::Eigen, RBF> { | |||
| typedef mapping::RadialBasisFctMapping<RadialBasisFctSolver<RBF>> type; | |||
| typedef mapping::RadialBasisFctMapping<RadialBasisFctSolver<RBF>, bool> type; | |||
| @@ -217,6 +217,8 @@ MappingConfiguration::MappingConfiguration( | |||
| auto attrPolynomial = makeXMLAttribute(ATTR_POLYNOMIAL, POLYNOMIAL_SEPARATE) | |||
| .setDocumentation("Toggles use of the global polynomial") | |||
| .setOptions({POLYNOMIAL_ON, POLYNOMIAL_OFF, POLYNOMIAL_SEPARATE}); | |||
| auto attrCrossValidation = makeXMLAttribute(ATTR_CROSS_VALIDATION, false) | |||
| .setDocumentation("Computes and logs a cross-validation error using the coupling data and the mapping matrix. This can be useful for tuning the basis function. Note that this might become computationally expensive."); | |||
There was a problem hiding this comment.
Suggested change
| .setDocumentation("Computes and logs a cross-validation error using the coupling data and the mapping matrix. This can be useful for tuning the basis function. Note that this might become computationally expensive."); | |
| .setDocumentation("Computes and logs a cross-validation error using coupling data and the mapping matrix. This can be useful for tuning the basis function. Note that this might become computationally expensive."); |
To make clearer that the mapping matrix is static and the data dynamic.
There was a problem hiding this comment.
Could we give an estimate on the "computationally expensive"? 5x higher than the mapping without cross validation or similar?
| mesh::PtrMesh inputMesh, | ||
| mesh::PtrMesh outputMesh); | ||
|
|
||
| /// Evaluates a conservative mapping and agglomerates the result in the given output data | ||
| void mapConservative(const time::Sample &inData, Eigen::VectorXd &outData) const; | ||
|
|
||
| /// Evaluates a consistent mapping and agglomerates the result in the given output data | ||
| void mapConsistent(const time::Sample &inData, Eigen::VectorXd &outData) const; | ||
| std::array<double, 3> mapConsistent(const time::Sample &inData, Eigen::VectorXd &outData) const; |
There was a problem hiding this comment.
The "3" is the number of components, right?
So, for scalar data the last two components will remain unused?
| } | ||
| std::vector<double> logErrors; | ||
| std::copy_n(maxErrors.begin(), inData.dataDims, std::back_inserter(logErrors)); | ||
| // Do we want to log every iteration about disabled error metrics? |
There was a problem hiding this comment.
No, why should we? I would remove this completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes of this PR
Follow-up on #2059, which makes the change user-configurable and enables a consistent logging.
Motivation and additional information
I left out the parallel aggregation for PUM, as it would introduce unnecessary communication.
Author's checklist
pre-commithook to prevent dirty commits and usedpre-commit run --allto format old commits.make changelogif there are user-observable changes since the last release.Please check the naming of the option, the logging and the default value.
Reviewers' checklist