Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional cpl-scheme to compositional test #1911

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

carme-hp
Copy link
Contributor

@carme-hp carme-hp commented Dec 1, 2023

Main changes of this PR

This PR modifies the system test TwoActivatedMuscles to include an additional serial-explicit coupling scheme.

Motivation and additional information

This is the follow up of #1514 (comment).
The addition of the proposed serial-explicit coupling scheme, is apparently not possible, as described in #1907.

Author's checklist

  • I used the pre-commit hook to prevent dirty commits and used pre-commit run --all to format old commits.
  • I added a changelog file with make changelog if there are user-observable changes since the last release.
  • I added a test to cover the proposed changes in our test suite.
  • For breaking changes: I documented the changes in the appropriate porting guide.
  • I sticked to C++17 features.
  • I sticked to CMake version 3.16.3.
  • I squashed / am about to squash all commits that should be seen as one.

Reviewers' checklist

  • Does the changelog entry make sense? Is it formatted correctly?
  • Do you understand the code changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants