Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate data writing and advancing coupling operations #17

Open
IshaanDesai opened this issue Jan 22, 2021 · 1 comment
Open

Separate data writing and advancing coupling operations #17

IshaanDesai opened this issue Jan 22, 2021 · 1 comment
Assignees
@IshaanDesai
Labels
enhancement
Milestone
v0.1.0

Comments

@IshaanDesai
Copy link
Member

Current the function fsi_write_and_advance has two core functionalities from the typical coupling time loop: (1) writing data to preCICE and (2) advancing preCICE.
For clarity it is favourable to separate these two functionalities into separate functions" write_data() and advance().
@IshaanDesai IshaanDesai self-assigned this Jan 22, 2021
@BenjaminRodenberg
Copy link
Member

I think that this is definitely something we should go for in a first release of the adapter, because it defines what the user sees and this should be consistent with the overall preCICE API. I don't think we absolutely need this for the first working version. Therefore, I will add it to the v0.1.0 milestone, but not to minimal working state.

@BenjaminRodenberg BenjaminRodenberg added this to the v0.1.0 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IshaanDesai IshaanDesai

Labels
enhancement
Projects
None yet
Milestone
v0.1.0
Development

No branches or pull requests
2 participants
@BenjaminRodenberg @IshaanDesai