fix bad state change in darwin update service

prateek · Jan 23, 2018 · f3ffbcf · f3ffbcf
1 parent 3ecae53
commit f3ffbcf
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/vs/platform/update/electron-main/updateService.darwin.ts b/src/vs/platform/update/electron-main/updateService.darwin.ts
@@ -36,12 +36,17 @@ export class DarwinUpdateService extends AbstractUpdateService {
 		@ILogService logService: ILogService
 	) {
 		super(lifecycleService, configurationService, environmentService, logService);
-		this.onRawError(this.logService.error, this.logService, this.disposables);
+		this.onRawError(this.onError, this, this.disposables);
 		this.onRawUpdateAvailable(this.onUpdateAvailable, this, this.disposables);
 		this.onRawUpdateDownloaded(this.onUpdateDownloaded, this, this.disposables);
 		this.onRawUpdateNotAvailable(this.onUpdateNotAvailable, this, this.disposables);
 	}
 
+	private onError(err: string): void {
+		this.logService.error('UpdateService error: ', err);
+		this.setState(State.Idle);
+	}
+
 	protected setUpdateFeedUrl(quality: string): boolean {
 		try {
 			electron.autoUpdater.setFeedURL(createUpdateURL('darwin', quality));