Merge remote-tracking branch 'origin/master' into selectToBracket

prateek · Jan 23, 2018 · d381a4b · d381a4b
2 parents 72e3cf9 + 84991c4
commit d381a4b
Show file tree

Hide file tree

Showing 3,198 changed files with 80,400 additions and 36,897 deletions.
diff --git a/.github/classifier.yml b/.github/classifier.yml
@@ -3,26 +3,54 @@
     alwaysRequireAssignee: false,
     labelsRequiringAssignee: [ feature-request ],
     autoAssignees: {
-        accessibility: [],
-        api: [],
+        api: {
+            assignees: [ jrieken ],
+            assignLabel: false
+        },
+        color-picker: [],
         css-less-sass: [],
-        debug: [ weinand ],
+        debug: {
+            assignees: [ isidorn ],
+            assignLabel: false
+        },
+        diff-editor: [],
         editor: [],
+        editor-1000-limit: [],
+        editor-autoclosing: [],
+        editor-autoindent: [],
         editor-brackets: [],
         editor-clipboard: [],
-        editor-colors: [],
+        editor-columnselect: [],
         editor-contrib: [],
         editor-core: [],
         editor-find-widget: [],
         editor-folding: [],
         editor-ime: [],
-        editor-indentation: [],
         editor-input: [],
         editor-minimap: [],
         editor-multicursor: [],
+        editor-smooth: [],
         editor-wrapping: [],
         emmet: [ ramya-rao-a ],
         error-list: [],
+        extensions: [],
+        file-encoding: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        file-io: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        file-watcher: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        file-explorer: {
+            assignees: [ isidorn ],
+            assignLabel: false
+        },
+        format: [],
         git: [ joaomoreno ],
         hot-exit: [ Tyriar ],
         html: [ aeschli ],
@@ -31,15 +59,88 @@
         integrated-terminal: [ Tyriar ],
         javascript: [ mjbvz ],
         json: [],
+        keybindings: [],
+        keyboard-layout: [],
         languages basic: [],
         markdown: [ mjbvz ],
         merge-conflict: [ chrmarti ],
+        multi-root: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
         perf-profile: [],
         php: [ roblourens ],
+        proxy: [],
+        remote: {
+            assignees: [ jrieken ],
+            assignLabel: false
+        },
+        scm: [],
         search: [ roblourens ],
-        snippets: [ jrieken ],
+        snippets: {
+            assignees: [ jrieken ],
+            assignLabel: false
+        },
         tasks: [ dbaeumer ],
+        telemetry: [],
+        themes: [],
         typescript: [ mjbvz ],
-        workbench: [ bpasero ]
+        workbench: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        workbench-dnd: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        workbench-editors: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        workbench-electron: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        workbench-feedback: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        workbench-history: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        workbench-layout: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        workbench-menu: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        workbench-notifications: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        workbench-state: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        workbench-status: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        workbench-tabs: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        workbench-title: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        workbench-touchbar: {
+            assignees: [ bpasero ],
+            assignLabel: false
+        },
+        workbench-welcome: [ chrmarti ]
     }
 }
diff --git a/.github/commands.yml b/.github/commands.yml
@@ -5,25 +5,37 @@
             type: 'label',
             name: '*question',
             action: 'close',
-            comment: "This issue has been closed because it represents a question. Questions are better addressed on [StackOverflow](https://aka.ms/vscodestackoverflow). See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
+            comment: "Please ask your question on [StackOverflow](https://aka.ms/vscodestackoverflow). We have a great community over [there](https://aka.ms/vscodestackoverflow). They have already answered thousands of questions and are happy to answer yours as well. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
+        },
+        {
+            type: 'label',
+            name: '*dev-question',
+            action: 'close',
+            comment: "We have a great developer community [over on slack](https://aka.ms/vscode-dev-community) where extension authors help each other. This is a great place for you to ask questions and find support.\n\nHappy Coding!"
         },
         {
             type: 'label',
             name: '*extension-candidate',
             action: 'close',
-            comment: "This issue has been closed because it is not within the scope of the core product, but could be addressed by an extension. The [VS Code Marketplace](https://aka.ms/vscodemarketplace) shows all existing extensions and you can get started [writing your own extension](https://aka.ms/vscodewritingextensions) in a few simple steps. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
+            comment: "We try to keep VS Code lean and we think the functionality you're asking for is great for a VS Code extension. Maybe you can already find one that suits you in the [VS Code Marketplace](https://aka.ms/vscodemarketplace). Just in case, in a few simple steps you can get started [writing your own extension](https://aka.ms/vscodewritingextensions). See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
         },
         {
             type: 'label',
             name: '*not-reproducible',
             action: 'close',
-            comment: "This issue has been closed because the problem could not be reproduced either because it is already fixed in later versions of the product or because it requires additional details on how to reproduce it. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
+            comment: "We closed this issue because we are unable to reproduce the problem with the steps you describe. Chances are we've already fixed your problem in a recent version of VS Code. If not, please ask us to reopen the issue and provide us with more detail. Our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines might help you with that.\n\nHappy Coding!"
         },
         {
             type: 'label',
             name: '*out-of-scope',
             action: 'close',
-            comment: "This feature request will not be considered in the next [6-12 months roadmap](https://aka.ms/vscoderoadmap) and has been closed to keep the number of issues we have to maintain manageable. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nThanks for your understanding and happy coding!"
+            comment: "This issue is being closed to keep the number of issues in our inbox on a manageable level, we are closing issues that have been on the backlog for a long time but have not gained traction: We look at the number of votes the issue has received and the number of duplicate issues filed. If you disagree and feel that this issue is crucial: We are happy to listen and to reconsider.\n\nIf you wonder what we are up to, please see our [roadmap](https://aka.ms/vscoderoadmap) and [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nThanks for your understanding and happy coding!"
+        },
+        {
+            type: 'label',
+            name: '*caused-by-extension',
+            action: 'close',
+            comment: "This issue is caused by an extension, please file it with the repository (or contact) the extension has linked in its overview in VS Code or the [marketplace](https://aka.ms/vscodemarketplace) for VS Code. See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
         },
         {
             type: 'comment',
@@ -36,7 +48,13 @@
             name: '*duplicate',
             allowTriggerByBot: true,
             action: 'close',
-            comment: "This issue has been closed because it is already tracked by another issue. See also our [GitHub issues](https://aka.ms/vscodeissuesearch) to search for existing issues and our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
+            comment: "Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues [here](https://aka.ms/vscodeissuesearch). See also our [issue reporting](https://aka.ms/vscodeissuereporting) guidelines.\n\nHappy Coding!"
+        },
+        {
+            type: 'comment',
+            name: 'confirm',
+            action: 'updateLabels',
+            addLabel: 'confirmed'
         },
     ]
 }
diff --git a/.github/insiders.yml b/.github/insiders.yml
@@ -1,4 +1,4 @@
 {
     insidersLabel: 'insiders',
-    perform: true
+    perform: false
 }
diff --git a/.github/issue_template.md b/.github/issue_template.md
@@ -1,6 +1,6 @@
-<!-- Do you have a question? Please ask it on http://stackoverflow.com/questions/tagged/vscode. -->
+<!-- Do you have a question? Please ask it on https://stackoverflow.com/questions/tagged/vscode. -->
 
-<!-- Use Help > Report Issues to prefill these. -->
+<!-- Use Help > Report Issue to prefill these. -->
 - VSCode Version:
 - OS Version:
 
@@ -10,4 +10,4 @@ Steps to Reproduce:
 2.
 
 <!-- Launch with `code --disable-extensions` to check. -->
-Reproduces without extensions: Yes/No
+Does this issue occur when all extensions are disabled?: Yes/No
diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+8.9.2
diff --git a/.travis.yml b/.travis.yml
@@ -31,6 +31,7 @@ addons:
       - libsecret-1-dev
 
 before_install:
+  - export GITHUB_TOKEN=$PUBLIC_GITHUB_TOKEN
   - git submodule update --init --recursive
   - git clone --depth 1 https://github.com/creationix/nvm.git ./.nvm
   - source ./.nvm/nvm.sh
@@ -51,12 +52,18 @@ install:
   - yarn
 
 script:
-  - node_modules/.bin/gulp hygiene
   - node_modules/.bin/gulp electron --silent
+  - node_modules/.bin/tsc -p ./src/tsconfig.monaco.json --noEmit
   - node_modules/.bin/gulp compile --silent --max_old_space_size=4096
-  - node_modules/.bin/gulp optimize-vscode --silent --max_old_space_size=4096
   - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then ./scripts/test.sh --coverage --reporter dot; else ./scripts/test.sh --reporter dot; fi
   - ./scripts/test-integration.sh
 
 after_success:
   - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then node_modules/.bin/coveralls < .build/coverage/lcov.info; fi
+
+matrix:
+  include:
+    - os: linux
+      env: label=hygiene
+      script: node_modules/.bin/gulp hygiene
+      after_success: skip
diff --git a/.vscode/launch.json b/.vscode/launch.json
@@ -129,6 +129,9 @@
 			"runtimeArgs": [
 				"--inspect=5875"
 			],
+			"skipFiles": [
+				"**/winjs*.js"
+			],
 			"webRoot": "${workspaceFolder}"
 		},
 		{

diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -10,6 +10,9 @@
 			"when": "$(basename).ts"
 		}
 	},
+	"files.associations": {
+		"OSSREADME.json": "jsonc"
+	},
 	"search.exclude": {
 		"**/node_modules": true,
 		"**/bower_components": true,
@@ -34,5 +37,6 @@
 				"command": "${workspaceFolder}\\scripts\\test.bat --coverage --run ${file}"
 			}
 		}
-	]
-}
+	],
+	"typescript.tsdk": "node_modules/typescript/lib"
+}