Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci)!: drop node 18 #9036

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

SourceR85
Copy link
Contributor

@SourceR85 SourceR85 commented Jan 4, 2025

Since v18 is EOL in April 25 anyway, I guess: now is the right time to drop it.

BREAKING CHANGE: drop support for Node.js v18

@alxndrsn
Copy link
Member

alxndrsn commented Jan 7, 2025

Looks like the node 22 addition is non-trivial; maybe the 2 changes can be separated?

@SourceR85 SourceR85 changed the title chore(ci): drop node 18, add 22 chore(ci): drop node 18 Jan 8, 2025
@SourceR85
Copy link
Contributor Author

Looks like the node 22 addition is non-trivial; maybe the 2 changes can be separated?

Sure, for v22 I'll add a separate PR when this is merged.

@alxndrsn
Copy link
Member

alxndrsn commented Jan 8, 2025

v18 is EOL in April 25

Should this be merged at the end of April? Then any versions released before then will still have been testing against v18.

@SourceR85
Copy link
Contributor Author

SourceR85 commented Jan 8, 2025

v18 is EOL in April 25

Should this be merged at the end of April? Then any versions released before then will still have been testing against v18.

Can be merged anytime (now would be the best time for it).

Let me try to convince you:
At first, it enables us to use some modern API's like URL.parse.

This patch will only affect the next release: PouchDB 10.0.0

It will be a major release and we have the freedom to do breaking changes as we've did it with Node 16 in PouchDB 9, like for example: drop support for Node 18 (very convenient 😉).
No one is forced to update to PouchDB 10.

PouchDB 9 is stable and nobody complains about security bugs (so far).
Iff someone find a vulnerability before 18 goes EOL, we can branch from https://github.com/pouchdb/pouchdb/tree/9.0.0 at any time to patch up a version 9.0.1.

Also: I expect that everyone has updated there Node runtime by now (or at least, they are working hard on the transition).

@SourceR85 SourceR85 changed the title chore(ci): drop node 18 chore(ci)!: drop node 18 Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants