-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci)!: drop node 18 #9036
base: master
Are you sure you want to change the base?
chore(ci)!: drop node 18 #9036
Conversation
Looks like the node 22 addition is non-trivial; maybe the 2 changes can be separated? |
Sure, for v22 I'll add a separate PR when this is merged. |
Should this be merged at the end of April? Then any versions released before then will still have been testing against v18. |
Can be merged anytime (now would be the best time for it). Let me try to convince you: This patch will only affect the next release: PouchDB 10.0.0 It will be a major release and we have the freedom to do breaking changes as we've did it with Node 16 in PouchDB 9, like for example: drop support for Node 18 (very convenient 😉). PouchDB 9 is stable and nobody complains about security bugs (so far). Also: I expect that everyone has updated there Node runtime by now (or at least, they are working hard on the transition). |
Since v18 is EOL in April 25 anyway, I guess: now is the right time to drop it.
BREAKING CHANGE: drop support for Node.js v18