Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: insert(Before|After) support multiple new node #302

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

btea
Copy link
Contributor

@btea btea commented Jan 5, 2025

No description provided.

insertAfter(oldNode: Child, newNode: Child): this;
insertBefore(oldNode: Child, newNode: Child): this;
insertAfter(oldNode: Child, ...newNode: Child[]): this;
insertBefore(oldNode: Child, ...newNode: Child[]): this;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type is wrong, it should be insertAfter(oldNode: Child, newNode: Child, ...restNode[]): this;

The first argument is required

Copy link
Collaborator

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants