Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resulting end position when endIndex is 0 for rangeBy #1932

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Fix resulting end position when endIndex is 0 for rangeBy #1932

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bea246
failing test: for endIndex 0 in rangeBy
romainmenke Mar 20, 2024
b45e7e9
fix endIndex
romainmenke Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix endIndex
  • Loading branch information
@romainmenke
romainmenke committed Mar 20, 2024
commit b45e7e915936803a7176f7131f16102571a610e8
2 changes: 1 addition & 1 deletion lib/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,7 +241,7 @@ class Node {
column: opts.end.column,
line: opts.end.line
}
} else if (opts.endIndex) {
} else if (typeof opts.endIndex === 'number') {
end = this.positionInside(opts.endIndex)
} else if (opts.index) {
end = this.positionInside(opts.index + 1)
Expand Down
Loading