Show error and disable deployment when environment and secrets have duplicates #2338
Conversation
dotNomad
requested review from
kgartland-rstudio,
sagerb and
marcosnav
as code owners
| <template v-if="home.duplicatedEnvironmentVariables.length === 1"> | ||
| A duplicate name was | ||
| </template> | ||
| <template v-if="home.duplicatedEnvironmentVariables.length > 1"> | ||
| Duplicate names were | ||
| </template> | ||
| found in Secrets and Environment. | ||
| <a | ||
| class="webview-link" | ||
| role="button" | ||
| @click=" | ||
| onEditConfiguration(home.selectedConfiguration!.configurationPath) | ||
| " | ||
| >Edit the Configuration</a | ||
| >. |
There was a problem hiding this comment.
What about saying something like "(A variable was|Variables were) set as both a secret and environment variable. (It|They) must only be in one or the other. Edit the Configuration." It's true that the names are the problem that's an issue, but at this point in the UX I think most people think of them more holistically and the names are below so it's clear that the names are the issue.
There was a problem hiding this comment.
Great suggestion. I really struggled coming up with text here and I think yours is a huge improvement. I'll make that change.
There was a problem hiding this comment.
Here is the UI with that text change with very minor adjustments. Let me know what you think.
Images
extensions/vscode/webviews/homeView/src/components/DeployButton.vue
Outdated
Show resolved
Hide resolved
dotNomad
force-pushed
the
dotnomad/secret-add
branch
from
abb4aec
to
4ddbbf3
Compare
dotNomad
force-pushed
the
dotnomad/envvar-overlap-err
branch
from
fb5f0f5
to
f72e8a5
Compare
We could merge this prior since it is a relatively simpler change, and componentize it with the other work. |
|
Verified the proper warning is shown if a Secret/Env Var collision occurs within the config. Deployment button remains active and deploys properly even if you forgo the warning. Verified an error message is thrown when adding a Secret where an already-existing Environment Variable. Tested on:
|
This PR adds a new error that disables deployment - similar to a missing credential error in style - when there are names shared in Environment and Secrets in the selected Configuration.
Preview
The duplicated names are present in the error to make it easier to resolve, along with a link to edit the configuration similar to other errors.
Intent
Resolves #2326
Type of Change