Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shell: Remove last workspace if it follows empty active workspace #1188

Merged
merged 1 commit into from
Feb 4, 2025
Merged

shell: Remove last workspace if it follows empty active workspace #1188

merged 1 commit into from
Feb 4, 2025

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Jan 30, 2025

Partly fixes pop-os/cosmic-workspaces-epoch#83, but it seems like there's at least one other issue with workspaces not being removed when they should be.

The if condition got a bit complicated here, so I've split it up and inverted the condition.

@ids1024
shell: Remove last workspace if it follows empty active workspace
0527b26 
Partly fixes
pop-os/cosmic-workspaces-epoch#83, but it
seems like there's at least one other issue with workspaces not being
removed when they should be.

The if condition got a bit complicated here, so I've split it up and
inverted the condition.
@ids1024 ids1024 requested a review from a team January 30, 2025 22:24
@ids1024
Copy link
Member Author

ids1024 commented Jan 30, 2025

Another issue here is pending_activations. retain_tokens removes tokens with a 5 second delay, so the token added with create_external_token() when it's not used make is_empty() on the workspace false until that delay is over.

Not sure the right change for that one.

@Drakulix
Copy link
Member

Drakulix commented Feb 4, 2025

Another issue here is pending_activations. retain_tokens removes tokens with a 5 second delay, so the token added with create_external_token() when it's not used make is_empty() on the workspace false until that delay is over.

Not sure the right change for that one.

The idea here is that windows should spawn on the workspace they were invoked on. So the right fix would probably be to re-run the cleanup logic once the 5 second delay runs out?

@Drakulix Drakulix merged commit 3b0aa9e into master Feb 4, 2025
6 checks passed
@Drakulix Drakulix deleted the workspaces_noble branch February 4, 2025 13:55
@ids1024 ids1024 mentioned this pull request Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Drakulix Drakulix Drakulix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Additional workspaces disappears upon switching
2 participants
@ids1024 @Drakulix