Merge pull request siddii#11 from nzalheart/master

Fixed the dynamic binding of feed url
pocketreceipt · Jul 1, 2015 · 83f7ced · 83f7ced
2 parents 58d27d6 + fa81901
commit 83f7ced
Showing 1 changed file with 19 additions and 17 deletions.
diff --git a/src/scripts/directives.js b/src/scripts/directives.js
@@ -28,23 +28,25 @@ angular.module('feeds-directives', []).directive('feed', ['feedService', '$compi
           }
         }
       }
-
-      feedService.getFeeds($attrs.url, $attrs.count).then(function (feedsObj) {
-        if ($attrs.templateUrl) {
-          $http.get($attrs.templateUrl, {cache: $templateCache}).success(function (templateHtml) {
-            renderTemplate(templateHtml, feedsObj);
-          });
-        }
-        else {
-          renderTemplate($templateCache.get('feed-list.html'), feedsObj);
-        }
-      },function (error) {
-        console.error('Error loading feed ', error);
-        $scope.error = error;
-        renderTemplate($templateCache.get('feed-list.html'));
-      }).finally(function () {
-        $element.find('.spinner').slideUp();
-        $scope.$evalAsync('finishedLoading = true')
+
+      $attrs.observe('url', function(url){
+        feedService.getFeeds(url, $attrs.count).then(function (feedsObj) {
+          if ($attrs.templateUrl) {
+            $http.get($attrs.templateUrl, {cache: $templateCache}).success(function (templateHtml) {
+              renderTemplate(templateHtml, feedsObj);
+            });
+          }
+          else {
+            renderTemplate($templateCache.get('feed-list.html'), feedsObj);
+          }
+        },function (error) {
+          console.error('Error loading feed ', error);
+          $scope.error = error;
+          renderTemplate($templateCache.get('feed-list.html'));
+        }).finally(function () {
+          $element.find('.spinner').slideUp();
+          $scope.$evalAsync('finishedLoading = true')
+        });          
       });
     }]
   }