Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve peer of peer from the deps of direct dependent package #7606

Merged
merged 43 commits into from
Feb 8, 2024
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
f27c9f4
fix: resolve peer of peer from the deps of direct dependent package
zkochan Feb 2, 2024
c0e08d8
test: fix
zkochan Feb 2, 2024
8589f8f
test: fix
zkochan Feb 2, 2024
188830b
test: add more tests
zkochan Feb 2, 2024
2b6febf
Merge remote-tracking branch 'origin/main' into fix-peers-resolution
zkochan Feb 3, 2024
3c3fdae
fix: wip
zkochan Feb 4, 2024
f3ac421
fix: wip
zkochan Feb 4, 2024
f9fe449
fix: wip
zkochan Feb 4, 2024
320a869
fix: wip
zkochan Feb 4, 2024
4ef2fd7
fix: wip
zkochan Feb 5, 2024
d23a9a8
fix: wip
zkochan Feb 5, 2024
c47a182
fix: wip
zkochan Feb 5, 2024
bbf4ab1
fix: wip
zkochan Feb 5, 2024
2aa831e
test: fix
zkochan Feb 5, 2024
f7d084d
fix: wip
zkochan Feb 6, 2024
21e28ec
fix: peers resolution
zkochan Feb 6, 2024
f95bf4f
test: fix
zkochan Feb 6, 2024
7cca596
test: fix
zkochan Feb 6, 2024
8ed1606
test: fix
zkochan Feb 6, 2024
81e65e9
perf: faster peers resolution
zkochan Feb 6, 2024
ddba271
refactor: resolve peers
zkochan Feb 6, 2024
9b66d64
test: refactor
zkochan Feb 7, 2024
e3ebf15
fix: graph-sequencer
zkochan Feb 7, 2024
6e625b0
perf: peers resolution
zkochan Feb 7, 2024
739e1f6
refactor: resolve peers
zkochan Feb 7, 2024
d0a8d4c
refactor: resolve peers
zkochan Feb 7, 2024
f3a24e7
refactor: resolve peers
zkochan Feb 7, 2024
7f24a67
refactor: resolve peers
zkochan Feb 7, 2024
25c02ca
Merge remote-tracking branch 'origin/main' into fix-peers-resolution
zkochan Feb 7, 2024
8df6c3f
Merge remote-tracking branch 'origin/main' into fix-peers-resolution
zkochan Feb 8, 2024
9018be8
Merge remote-tracking branch 'origin/main' into fix-peers-resolution
zkochan Feb 8, 2024
510514f
docs: update changeset
zkochan Feb 8, 2024
d9adade
refactor: dependency-path
zkochan Feb 8, 2024
3ae5a4a
fix: resolving circular peers from root
zkochan Feb 8, 2024
6dc1284
Revert "fix: graph-sequencer"
zkochan Feb 8, 2024
aa2704b
fix: resolving circular peers from root
zkochan Feb 8, 2024
ec979f3
Revert "Revert "fix: graph-sequencer""
zkochan Feb 8, 2024
8015879
fix: installing deps with circular peers
zkochan Feb 8, 2024
eb5077e
Revert "Revert "Revert "fix: graph-sequencer"""
zkochan Feb 8, 2024
3bd416f
fix: types
zkochan Feb 8, 2024
835f214
Merge branch 'main' into fix-peers-resolution
zkochan Feb 8, 2024
23845ca
test: add test to graph-sequencer
zkochan Feb 8, 2024
3da0ad0
test: use smaller packages for testing
zkochan Feb 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: wip
  • Loading branch information
zkochan committed Feb 6, 2024
commit f7d084da30a952bd66fd7650e73b013c50467b8a
4 changes: 3 additions & 1 deletion pkg-manager/resolve-dependencies/src/resolvePeers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,9 @@ function resolvePeersOfChildren<T extends PartialResolvedPackage> (
const [repeated, notRepeated] = partition(([alias]) => parentPkgs[alias] != null, Object.entries(children))

for (const [,nodeId] of [...notRepeated, ...repeated]) {
ctx.pathsByNodeIdPromises.set(nodeId, pDefer())
if (!ctx.pathsByNodeIdPromises.has(nodeId)) {
ctx.pathsByNodeIdPromises.set(nodeId, pDefer())
}
}

// Resolving non-repeated nodes before repeated nodes proved to be slightly faster.
Expand Down