Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: don't include registry URL in package ID #7476

Merged
merged 9 commits into from
Jan 3, 2024
Merged

feat!: don't include registry URL in package ID #7476

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7aba125
feat!: don't include registry URL in package ID
zkochan Jan 1, 2024
5712ba2
test: fix
zkochan Jan 1, 2024
998f46b
test: fix
zkochan Jan 1, 2024
6ebbfd2
test: fix
zkochan Jan 2, 2024
2081054
test: fix
zkochan Jan 2, 2024
b61ae50
refactor: remove refToAbsolute
zkochan Jan 2, 2024
3b87a5c
refactor: depPathToRef
zkochan Jan 2, 2024
522d4c6
test: fix
zkochan Jan 3, 2024
154d21c
docs: add changeset
zkochan Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: fix
  • Loading branch information
@zkochan
zkochan committed Jan 2, 2024
commit 20810544ca6c4bfad5f3481b6a28cc13e59b6d3a
2 changes: 1 addition & 1 deletion store/server/test/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ test('server', async () => {

const { bundledManifest, files } = await response.fetching!()
expect(bundledManifest?.name).toBe('is-positive')
expect(response.body.id).toBe('registry.npmjs.org/is-positive@1.0.0')
expect(response.body.id).toBe('/is-positive@1.0.0')

expect(response.body.manifest!.name).toBe('is-positive')
expect(response.body.manifest!.version).toBe('1.0.0')
Expand Down
Loading