Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I did notice that one of the paths mentioned has an unmatched closing paren: #7631

Closed
zkochan opened this issue Feb 9, 2024 · 2 comments · Fixed by #7632
Closed

I did notice that one of the paths mentioned has an unmatched closing paren: #7631

zkochan opened this issue Feb 9, 2024 · 2 comments · Fixed by #7632

Comments

@zkochan
Copy link
Member

zkochan commented Feb 9, 2024

          I did notice that one of the paths mentioned has an unmatched closing paren:
types/react-native-safari-view/node_modules/.pnpm/react-native@0.73.4_@babel+core@7.23.9_@babel+preset-env@7.23.9_@babel+core@7.23.9)_react@18.2.0/node_modules/react-native/Libraries/Animated/Animated.d.ts

image

Which may be a bug in this PR.

Originally posted by @jakebailey in #7606 (comment)

@jakebailey
Copy link
Member

jakebailey commented Feb 9, 2024

This is not a small repro, but you can do:

$ git clone --filter blob:none https://github.com/DefinitelyTyped/DefinitelyTyped.git
$ cd DefinitelyTyped
$ node /path/to/pnpm.cjs install --filter '{./types/react-native-safari-view}...`
$ ls types/react-native-safari-view/node_modules/.pnpm | grep ')'
@react-native+babel-plugin-codegen@0.73.4_@babel+preset-env@7.23.9_@babel+core@7.23.9)
@react-native+babel-preset@0.73.21_@babel+core@7.23.9_@babel+preset-env@7.23.9_@babel+core@7.23.9)
@react-native+codegen@0.73.3_@babel+preset-env@7.23.9_@babel+core@7.23.9)
@react-native+community-cli-plugin@0.73.16_@babel+core@7.23.9_@babel+preset-env@7.23.9_@babel+core@7.23.9)
@react-native+metro-babel-transformer@0.73.15_@babel+core@7.23.9_@babel+preset-env@7.23.9_@babel+core@7.23.9)
jscodeshift@0.14.0_@babel+preset-env@7.23.9_@babel+core@7.23.9)
react-native@0.73.4_@babel+core@7.23.9_@babel+preset-env@7.23.9_@babel+core@7.23.9)_react@18.2.0

All of these are missing the open paren.

@zkochan
Copy link
Member Author

zkochan commented Feb 9, 2024

The easiest solution would be just to use the paren and not convert it to _. It would make the directory names longer though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants