Skip to content

The "--lockfile-only" flag still downloads the full tarball for every dependency #1328

Closed
@octogonz

Description

pnpm version: 2.13.5

Code to reproduce the issue:

Run pnpm install --shrinkwrap-only.

My understanding was that this feature allows people to update their shrinkwrap.yaml file very quickly, in situations where they aren't going to be building anything locally, so they don't need their node_modules folder to be updated. (For example, I'm going to push the updated shrinkwrap.yaml to a PR branch, and I optimistically expect the PR build to succeed, so there's no reason to build it locally.)

Expected behavior:

Run pnpm install --shrinkwrap-only runs very quickly.

Actual behavior:

Run pnpm install --shrinkwrap-only takes about the same amount of time as a regular pnpm install --shrinkwrap-only.

If that's by design, perhaps we should deprecate the --shrinkwrap-only flag? Or perhaps I am misunderstanding its purpose?

Additional information:

This is apparently a recent regression due to the work with corgi headers. See @nickpape-msft 's comments on #1177 (comment) for background.

  • node -v prints: 8.9.4
  • Windows, OS X, or Linux?: Windows

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions