Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for port long syntax #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for port long syntax #62

wants to merge 1 commit into from

Conversation

theitalianz
Copy link

@theitalianz theitalianz commented Jan 31, 2022 •
edited
Loading

Use case: https://docs.docker.com/compose/compose-file/compose-file-v3/#ports

  ports:
  - published: 80
    target: 8080
  - published: 9101
    target: 9101

@theitalianz theitalianz changed the title Support for ports long syntax Support for port long syntax Jan 31, 2022
@theitalianz theitalianz mentioned this pull request Jan 31, 2022
Open
@benyafai
Copy link

Would it make more sense to make the if (is_array($port)) { ... } portion inside of the explodePortMapping function instead of breaking it away from there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theitalianz @benyafai @stfnzl