Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): recompute dependents in edge cases #2742

Merged
merged 9 commits into from
Oct 15, 2024
Merged

fix(core): recompute dependents in edge cases #2742

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d0a67ac
add failing test
dai-shi Sep 19, 2024
256b0d2
wip: a tentative fix for this special case
dai-shi Sep 19, 2024
09b84bc
complicate the test to make it fail
dai-shi Sep 19, 2024
170dc0f
Merge branch 'main' into bug-2738
dai-shi Sep 24, 2024
cd67e40
wip: remove force flag
dai-shi Oct 8, 2024
b94deb9
Merge branch 'main' into bug-2738
dai-shi Oct 8, 2024
21d45e5
Merge branch 'main' into bug-2738
dai-shi Oct 9, 2024
b3a7793
comment
dai-shi Oct 9, 2024
79adf23
Merge branch 'main' into bug-2738
dai-shi Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
add failing test
  • Loading branch information
@dai-shi
dai-shi committed Sep 19, 2024
commit d0a67accd0d52b747438402b24601856293b374d
34 changes: 33 additions & 1 deletion tests/vanilla/dependency.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { expect, it } from 'vitest'
import { expect, it, vi } from 'vitest'
import { atom, createStore } from 'jotai/vanilla'

it('can propagate updates with async atom chains', async () => {
Expand Down Expand Up @@ -288,3 +288,35 @@ it('refreshes deps for each async read', async () => {
resolve.splice(0).forEach((fn) => fn())
expect(values).toEqual([0, 1])
})

it('should not re-evaluate stable derived atom values in situations where dependencies are re-ordered (#2738)', () => {
const callCounter = vi.fn()
const rootAtom = atom(false)
const stableDep = atom((get) => {
get(rootAtom)
return 1
})
const stableDepDep = atom((get) => {
get(stableDep)
callCounter()
return 2
})

const newAtom = atom((get) => {
if (get(rootAtom)) {
return get(stableDepDep)
}

return get(stableDep)
})

const store = createStore()
store.sub(stableDepDep, () => {})
store.sub(newAtom, () => {})
expect(store.get(stableDepDep)).toBe(2)
expect(callCounter).toHaveBeenCalledTimes(1)

store.set(rootAtom, true)
expect(store.get(newAtom)).toBe(2)
expect(callCounter).toHaveBeenCalledTimes(1)
})
Loading