Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Text): downstream tree-shaking & *BufferGeometry deprecation #1145

Merged
merged 10 commits into from
Dec 15, 2022
Merged

fix(Text): downstream tree-shaking & *BufferGeometry deprecation #1145

merged 10 commits into from
Dec 15, 2022

Conversation

CodyJasonBennett
Copy link
Member

Fixes withstanding issues with troika-three-text and tree-shaking as well as recent three deprecations of PlaneBufferGeometry => PlaneGeometry. I've had to vendor the package since this is a breaking change there.

@vercel
Copy link

vercel bot commented Nov 13, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
drei ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 5:07AM (UTC)

@CodyJasonBennett CodyJasonBennett marked this pull request as draft November 13, 2022 20:16
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 13, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit afcb8f3:

Sandbox Source
relaxed-rgb-leld89 Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@drcmda
Copy link
Member

drcmda commented Nov 13, 2022

could we ask troika for an update rather? if its breaking they could release a major. afraid that once we move vendors here keeping this up to date will become an obstacle.

@CodyJasonBennett
Copy link
Member Author

CodyJasonBennett commented Nov 13, 2022 •
edited
Loading

I've been looking into fixing this in troika-three-text itself, it would bump three peer deps to r125+. There are IIFEs all over the codebase, that would have to be fixed separately for tree-shaking. I have that applied here for testing purposes.

@CodyJasonBennett
Copy link
Member Author

protectwise/troika#225, protectwise/troika#224.

@drcmda
Copy link
Member

drcmda commented Nov 19, 2022

@CodyJasonBennett peer deps to r125+ imo is no problem, that's ancient.

@CodyJasonBennett CodyJasonBennett changed the title fix: vendor troika-three-text, resolve tree-shaking & *BufferGeometry deprecation fix(Text): downstream tree-shaking & *BufferGeometry deprecation Dec 15, 2022
@CodyJasonBennett CodyJasonBennett marked this pull request as ready for review December 15, 2022 05:04
@CodyJasonBennett CodyJasonBennett merged commit c20af06 into pmndrs:master Dec 15, 2022
@CodyJasonBennett CodyJasonBennett deleted the fix/troika-text branch December 15, 2022 05:11
@CodyJasonBennett CodyJasonBennett removed the request for review from drcmda December 15, 2022 05:11
@github-actions
Copy link

🎉 This PR is included in version 9.46.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CodyJasonBennett @drcmda