add wasm builds; requires emsdk path #1928
Draft
+102
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dromer
force-pushed
the
feature/heavy-js
branch
from
c128d79 to
586fad9
Compare
dromer
force-pushed
the
feature/heavy-js
branch
from
586fad9 to
6849d64
Compare
|
It's probably a better UX if the user can navigate to the SDK path directly. So this needs some tweaking for the emsdkPathValue input. |
dromer
commented
Nov 12, 2024
| @@ -39,7 +40,8 @@ class ExporterSettingsPanel : public Component | |||
| "C++ Code", | |||
| "Electro-Smith Daisy", | |||
| "DPF Audio Plugin", | |||
| "Pd External" | |||
| "Pd External", | |||
| "JS / WebAssembly" | |||
There was a problem hiding this comment.
Or should we just call it WebAssembly?
(it looks a bit off like this)
dromer
commented
Jan 9, 2025
| @@ -100,6 +103,7 @@ class ExporterSettingsPanel final : public Component | |||
| state.appendChild(views[1]->getState(), nullptr); | |||
| state.appendChild(views[2]->getState(), nullptr); | |||
| state.appendChild(views[3]->getState(), nullptr); | |||
| state.appendChild(views[4]->getState(), nullptr); | |||
There was a problem hiding this comment.
I see now there is a conflict with OWL feature.
We can merge that one first and then adjust accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, but already works on my machine ;)
Also it should have a check that fails early when the user didn't enter any emsdk path.
I wonder if for Windows we can just use the
emsdk_env.shsince we run everything in a bash shell, so definitely needs some testing on all platforms.