Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser failure in table-visual-test #3091

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Fix browser failure in table-visual-test #3091

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d5153b
Change table-visual-test image to cimg/node-lts-browsers
T4rk1n Nov 22, 2024
856905b
remove chrome version from table-visual-test
T4rk1n Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -540,7 +540,7 @@ jobs:
table-visual-test:
working_directory: ~/dash/components/dash-table
docker:
- image: cimg/node:16.13-browsers
- image: cimg/node:lts-browsers
environment:
PERCY_TOKEN: $PERCY_TOKEN_TABLE

Expand All @@ -551,7 +551,6 @@ jobs:
- restore_cache:
key: dep-{{ .Branch }}-{{ checksum "package-lock.json" }}-{{ checksum "package.json" }}
- browser-tools/install-browser-tools:
chrome-version: 120.0.6099.71
install-firefox: false
install-geckodriver: false
- run:
Expand Down