-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add long_callback decorator #1702
Merged
+1,492
−3
Merged
Changes from 1 commit
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
0c1a053
Add long_callback decorator
jonmmease 5a004e7
Rework long_callback to avoid disabling interval until all requests a…
jonmmease f5dfd6b
Add long_callback tests
jonmmease 0b10624
Have the diskcache long_callback manager rely on multiprocess on all …
jonmmease 813fc00
long_callback docstring
jonmmease 4ddecf2
Fix import
jonmmease 1ac543e
flakes
jonmmease aa676bd
pylint
jonmmease 5ff33cf
Python 3.6 compat
jonmmease 1da38be
Refactor long calblack mangaers and tests
jonmmease 02b36df
Add cache_args_to_skip option to long_callback
jonmmease a1b8a39
Add dual long_callback test
jonmmease 5d64332
Add dual long_callback test
jonmmease d50f214
celery tests on circleci (take 1)
jonmmease 809f5da
pylist fixes
jonmmease 9ed1b81
pylist fixes
jonmmease f5eec9d
CI WIP
jonmmease f79bde3
CI WIP (2)
jonmmease cc82b59
Re-enable tests
jonmmease b92f89f
Support single list input argument
jonmmease e2bd875
Raise informative error when dependency to long_callback has pattern-…
jonmmease 71227cd
Remove module string from celery task name hash
jonmmease 41520e5
validate that celery app has result backend configured
jonmmease e5f967e
Test celery manager with multiple celery workers
jonmmease 2405f11
Add long callback manager docstrings
jonmmease 7e0f386
bump up test wait times
jonmmease 4b7ec3c
Don't fail on NoSuchProcess exception
jonmmease 5731edf
Don't fail on NoSuchProcess exception (2)
jonmmease c07fe63
Merge remote-tracking branch 'origin/dev' into long_callback
jonmmease 56ad571
Add CHANGELOG entry
jonmmease 3733909
Merge remote-tracking branch 'origin/dev' into long_callback
jonmmease 9134207
Add extra components to validation_layout and fix prevent_initial_call
jonmmease e5d538d
Merge remote-tracking branch 'origin/dev' into long_callback
jonmmease 92d7c04
Increase sleep time to allow final app state to settle
jonmmease 3892ecb
Increase sleep time to allow final app state to settle
jonmmease File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
Increase sleep time to allow final app state to settle
commit 3892ecb3ea878561210db8a16176c42dd2097417
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though the first sentence should be clear, the second sentence makes it sound like you can just give the class, like
long_callback_manager=DiskcacheLongCallbackManager
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. updated in 3892ecb (apologies for the bogus commit message)