add condition to avoid ghost request

plotly · byronz · Nov 8, 2019 · Nov 1, 2019 · Nov 1, 2019 · Nov 1, 2019
commit 7e46b6edf68bb6ea69a2c84cc22ac6b59354adb2
@@ -109,7 +109,7 @@ def percy_snapshot(self, name="", wait_for_callbacks=False):
         )
         logger.info("taking snapshot name => %s", snapshot_name)
         if wait_for_callbacks:
-            until(self._wait_for_callbacks, timeout=60)
+            until(self._wait_for_callbacks, timeout=30)
         self.percy_runner.snapshot(name=snapshot_name)
 
     def take_snapshot(self, name):

@@ -45,9 +45,13 @@ def window_store(self):
 
     def _wait_for_callbacks(self):
         if self.window_store:
-            logger.warning("status of state rq %s", self.redux_state_rqs)
+            logger.debug("status of state rq %s", self.redux_state_rqs)
             return self.redux_state_rqs and all(
-                (_.get("responseTime") for _ in self.redux_state_rqs)
+                (
+                    _.get("responseTime")
+                    for _ in self.redux_state_rqs
+                    if _.get("controllerId")
+                )
             )
         return True