Merge pull request #923 from AnnMarieW/disable-autocomplet-dropdown-#808

sets autoComplete to off in Dropdown #808
plotly · Feb 1, 2021 · 2b95f31 · 2b95f31
1 parent c0a1cf8
commit 2b95f31
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 0 deletions.
diff --git a/packages/dash-core-components/CHANGELOG.md b/packages/dash-core-components/CHANGELOG.md
@@ -2,6 +2,12 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## UNRELEASED
+
+### Changed
+- [#923](https://github.com/plotly/dash-core-components/pull/923)
+  Set autoComplete to off in `dcc.Dropdown`. This fixes [#808](https://github.com/plotly/dash-core-components/issues/808)
+
 ## [1.15.0] - 2021-01-19
 ### Fixed
 - [#905](https://github.com/plotly/dash-core-components/pull/905) Make sure the `figure` prop of `dcc.Graph` receives updates from user interactions in the graph, by using the same `layout` object as provided in the prop rather than cloning it. Fixes [#879](https://github.com/plotly/dash-core-components/issues/879).

diff --git a/packages/dash-core-components/src/fragments/Dropdown.react.js b/packages/dash-core-components/src/fragments/Dropdown.react.js
@@ -97,6 +97,7 @@ export default class Dropdown extends Component {
                     onInputChange={search_value => setProps({search_value})}
                     backspaceRemoves={clearable}
                     deleteRemoves={clearable}
+                    inputProps={{autoComplete: 'off'}}
                     {...omit(['setProps', 'value'], this.props)}
                 />
             </div>

diff --git a/packages/dash-core-components/tests/unit/Dropdown.test.js b/packages/dash-core-components/tests/unit/Dropdown.test.js
@@ -18,6 +18,7 @@ describe('Props can be set properly', () => {
             {label: 'Disabled', value: 'x', disabled: true},
         ],
         value: 2,
+        autoComplete: 'off',
         optionHeight: 50,
         className: 'dd-class',
         clearable: true,