Skip to content

Commit

Permalink
[e2e] Quarantine tests effected by slower VMI deletion issue
Browse files Browse the repository at this point in the history
There is an issue with slower VMI deletion[1] that is causing widespread
test flakes which is severely impacting CI.

Quarantine the three tests that are flaking the most due to this issue.

[1] https://issues.redhat.com/browse/CNV-36682

Signed-off-by: Brian Carey <bcarey@redhat.com>
  • Loading branch information
brianmcarey committed Jan 22, 2024
1 parent 0a3141f commit e3583b4
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions tests/pool_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ var _ = Describe("[sig-compute]VirtualMachinePool", decorators.SigCompute, func(
Expect(err.Error()).To(ContainSubstring("admission webhook \"virtualmachinepool-validator.kubevirt.io\" denied the request: spec.virtualMachineTemplate.spec.template.spec.domain.devices.disks[2].Name 'testdisk' not found"))
})

It("should remove VMs once they are marked for deletion", func() {
It("[QUARANTINE] should remove VMs once they are marked for deletion", decorators.Quarantine, func() {
newPool := newVirtualMachinePool()
// Create a pool with two replicas
doScale(newPool.ObjectMeta.Name, 2)
Expand Down Expand Up @@ -441,7 +441,7 @@ var _ = Describe("[sig-compute]VirtualMachinePool", decorators.SigCompute, func(
}, 5*time.Second, 1*time.Second).Should(BeNil())
})

It("should roll out VMI template changes and proactively roll out new VMIs", func() {
It("[QUARANTINE] should roll out VMI template changes and proactively roll out new VMIs", decorators.Quarantine, func() {
newPool := newVirtualMachinePool()
doScale(newPool.ObjectMeta.Name, 1)
waitForVMIs(newPool.Namespace, 1)
Expand Down
2 changes: 1 addition & 1 deletion tests/replicaset_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ var _ = Describe("[rfe_id:588][crit:medium][vendor:cnv-qe@redhat.com][level:comp
}, 10*time.Second, 1*time.Second).Should(Equal(int32(2)))
})

It("[test_id:1418]should replace finished VMIs", func() {
It("[test_id:1418][QUARANTINE] should replace finished VMIs", decorators.Quarantine, func() {
By("Creating new replica set")
rs := newReplicaSet()
doScale(rs.ObjectMeta.Name, int32(2))
Expand Down

0 comments on commit e3583b4

Please sign in to comment.