tests: network: replace AddExplicitPodNetworkInterface()

libvmi.WithMasqueradeNetworking is so much nicer and seemingly does the same. Signed-off-by: Dan Kenigsberg <danken@redhat.com>
pkenchap · Jan 26, 2024 · b6e211f · b6e211f
1 parent df3dbdb
commit b6e211f
Showing 1 changed file with 3 additions and 6 deletions.
diff --git a/tests/network/vmi_networking.go b/tests/network/vmi_networking.go
@@ -508,8 +508,7 @@ var _ = SIGDescribe("[rfe_id:694][crit:medium][vendor:cnv-qe@redhat.com][level:c
 
 		It("[test_id:1776]should configure custom Pci address", func() {
 			By("checking eth0 Pci address")
-			testVMI := libvmi.NewAlpine()
-			tests.AddExplicitPodNetworkInterface(testVMI)
+			testVMI := libvmi.NewAlpine(libvmi.WithMasqueradeNetworking()...)
 			testVMI.Spec.Domain.Devices.Interfaces[0].PciAddress = "0000:01:00.0"
 			testVMI, err = virtClient.VirtualMachineInstance(testsuite.GetTestNamespace(nil)).Create(context.Background(), testVMI)
 			Expect(err).ToNot(HaveOccurred())
@@ -559,10 +558,8 @@ var _ = SIGDescribe("[rfe_id:694][crit:medium][vendor:cnv-qe@redhat.com][level:c
 	Context("VirtualMachineInstance with dhcp options", func() {
 		It("[test_id:1778]should offer extra dhcp options to pod iface", func() {
 			libnet.SkipWhenClusterNotSupportIpv4()
-			dhcpVMI := libvmi.NewFedora()
-			tests.AddExplicitPodNetworkInterface(dhcpVMI)
-
-			dhcpVMI.Spec.Domain.Resources.Requests[k8sv1.ResourceName("memory")] = resource.MustParse("1024M")
+			dhcpVMI := libvmi.NewFedora(append(libvmi.WithMasqueradeNetworking(),
+				libvmi.WithResourceMemory("1024M"))...)
 
 			// This IPv4 address tests backwards compatibility of the "DHCPOptions.NTPServers" field.
 			// The leading zero is intentional.