Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Mount your own rsgain preset file #2

Merged
merged 3 commits into from
Jun 21, 2024
Merged

feat: Mount your own rsgain preset file #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e71267d
If not empty, use user preset file instead of no_album (default)
pjmeca Jun 21, 2024
b815c2c
Update README and upgrade minor
pjmeca Jun 21, 2024
4c17325
Update docker cmd with new volume
pjmeca Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ LABEL org.label-schema.name="pjmeca/volume-normalizer" \
org.label-schema.description="This Docker image normalizes the volume of your entire music library using rsgain." \
org.label-schema.url="https://hub.docker.com/r/pjmeca/volume-normalizer" \
org.label-schema.vcs-url="https://github.com/pjmeca/volume-normalizer" \
org.label-schema.version="1.1.0" \
org.label-schema.version="1.2.0" \
org.label-schema.schema-version="1.0.0-rc.1" \
org.label-schema.docker.cmd="docker run -d --name volume-normalizer -v /your/main/music/path:/mnt -v /etc/localtime:/etc/localtime:ro -e CRON_SCHEDULE=\"0 4 * * *\" --restart unless-stopped pjmeca/volume-normalizer:latest" \
org.label-schema.docker.cmd="docker run -d --name volume-normalizer -v /your/main/music/path:/mnt -v /your/preset.ini:/root/.config/rsgain/presets/user_preset.ini:ro -v /etc/localtime:/etc/localtime:ro -e CRON_SCHEDULE=\"0 4 * * *\" --restart unless-stopped pjmeca/volume-normalizer:latest" \
maintainer="pjmeca"
WORKDIR /app
ENV CRON_SCHEDULE="0 */1 * * *"
Expand All @@ -27,6 +27,8 @@ RUN apt-get update && \
apt install -y --no-install-recommends /tmp/rsgain.deb && \
apt-get clean && \
rm -rf /var/lib/apt/lists/* /tmp/rsgain.deb
RUN mkdir -p ~/.config/rsgain/presets && \
touch ~/.config/rsgain/presets/user_preset.ini
COPY start_rsgain.sh start.sh ./
RUN chmod +x start_rsgain.sh start.sh
CMD ["./start.sh"]
10 changes: 6 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,12 @@ You can find the Dockerfile and all the resources I used to create this image in

## Usage

The following example creates a container that normalizes your music library everyday at 4 AM.
The following example creates a container that normalizes your music library everyday at 4 AM. You can define your own presets by mounting a preset file (by default, the `no_album` preset is used).

### Using docker run:

```sh
docker run -d --name volume-normalizer -v /your/main/music/path:/mnt -v /etc/localtime:/etc/localtime:ro -e CRON_SCHEDULE="0 4 * * *" --restart unless-stopped pjmeca/volume-normalizer:latest
docker run -d --name volume-normalizer -v /your/main/music/path:/mnt -v /your/preset.ini:/root/.config/rsgain/presets/user_preset.ini:ro -v /etc/localtime:/etc/localtime:ro -e CRON_SCHEDULE="0 4 * * *" --restart unless-stopped pjmeca/volume-normalizer:latest
```

### Using docker-compose:
Expand All @@ -27,6 +27,7 @@ services:
container_name: volume-normalizer
volumes:
- /your/main/music/path:/mnt # Change this
#- /your/preset.ini:/root/.config/rsgain/presets/user_preset.ini:ro # Custom preset
- /etc/localtime:/etc/localtime:ro
environment:
CRON_SCHEDULE: "0 4 * * *" # Customize your cron if needed
Expand Down Expand Up @@ -66,13 +67,14 @@ Sleeping until next run.
Here are some pending ideas that I might try to implement if needed. I am open to suggestions.

- [x] Reduce image size
- [ ] Optionally pass arguments to rsgain using environment variables
- [x] ~~Optionally pass arguments to rsgain using environment variables~~ A preset file will be used instead (suggested in [#1](https://github.com/pjmeca/volume-normalizer/issues/1))
- [ ] Omit previously scanned files (possibly by storing them in a SQLite database)

## Changelog

- 1.0.0: Initial release
- 1.2.0: Mount a custom preset file
- 1.1.0: Reduce Docker image size
- 1.0.0: Initial release

## Special Thanks To

Expand Down
1 change: 1 addition & 0 deletions docker-compose_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ services:
- linux/amd64
volumes:
- /your/main/music/path:/mnt # Change this
#- /your/preset.ini:/root/.config/rsgain/presets/user_preset.ini:ro # Custom preset
- /etc/localtime:/etc/localtime:ro
environment:
CRON_SCHEDULE: "* * * * *" # Customize your cron if needed
Expand Down
1 change: 1 addition & 0 deletions docker-compose_release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ services:
container_name: volume-normalizer
volumes:
- /your/main/music/path:/mnt # Change this
#- /your/preset.ini:/root/.config/rsgain/presets/user_preset.ini:ro # Custom preset
- /etc/localtime:/etc/localtime:ro
environment:
CRON_SCHEDULE: "0 4 * * *" # Customize your cron if needed
Expand Down
8 changes: 7 additions & 1 deletion start_rsgain.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@

echo "Starting rsgain..."

/usr/bin/rsgain easy -m MAX -p no_album /mnt
if [ -s ~/.config/rsgain/presets/user_preset.ini ]; then
preset=user_preset
else
preset=no_album
fi

/usr/bin/rsgain easy -m MAX -p $preset /mnt
# -m MAX: use max number of threads
# -p no_album: disable album tags

Expand Down