Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for python 3.3 and 3.4` + workaround for testing #225

Merged
merged 3 commits into from
Sep 2, 2018

Conversation

menshikh-iv
Copy link
Contributor

Done:

CC: @mpenkov @piskvorky

'boto3'
# Temporary pin boto3 & botocore, because moto doesn't work with new version
# See https://github.com/spulec/moto/issues/1793
'boto3 < 1.8.0',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't moto needed only for testing? install_requires affects all users… should we restrict them from using newer boto3/botocore, just because of our testing dependency?

Copy link
Contributor Author

@menshikh-iv menshikh-iv Sep 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moto needed only for testing, that's true, I understand that this influences to all users, but this is "temporary" only (no big deal if we slightly limit boto version for some time).

As an alternative solution, I can revert this boto* restriction and instead of it, install pinned versions manually (for Travis only), this can be a better solution (because don't affect to users), wdyt @piskvorky @mpenkov?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to you; of course not limiting users is preferable, but it's probably no big deal, like you say.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can’t run our unit tests with the newest boto3, then can we be sure
things really work with that boto3 version?

If the answer is no, then we should restrict our users to boto3 versions that we know work.

Copy link
Owner

@piskvorky piskvorky Sep 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. It looks like the guys at moto are trying to resolve this.

But if they fail we'll have to unpin or do testing differently, because pinning a core library (boto3) to an old / obsolete version (a step that affects users), just to appease a testing library that users don't care about (moto) is only a temporary hack, like @menshikh-iv says.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking things downstream from you, 17 days later.

Please revert this, or move to a development-only dependency, or else it will be necessary for us to stop using this library.

Copy link
Contributor Author

@menshikh-iv menshikh-iv Sep 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petergaultney hi, can you please describe, why does it break something? What's a problem with it? Anyway, you still can use the previous version of smart_open without pinning if this very important for you.

Copy link
Contributor Author

@menshikh-iv menshikh-iv Sep 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related issue #227, anyway, thanks for report @petergaultney, I'll try my best to fix it ASAP

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, #227 is my exact issue! thanks!

@menshikh-iv menshikh-iv merged commit 1d7538f into master Sep 2, 2018
@menshikh-iv menshikh-iv deleted the drop-old-3 branch September 2, 2018 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants